asp.net mvc adding validation causes Model to be null

Question

i just about finished my first asp.net mvc site but i wasn't happy with the robustness of the validation.

i read up on validation and then added the below code to my Edit action in my UsersController:

  if (user_.firstname.Trim().Length == 0)
        {
            ModelState.AddModelError("firstname", "First Name is required.");
            return View();
        }

i just did a test on this and i now am getting errors in my view where the Model is null.

<% using (Html.BeginForm())
   {%>
<fieldset>
    <legend>Fields</legend>
    <p>
        <label for="Email">
            Login Name:
            <%= Model.loginName%>
        </label>
    </p>
    <p>

So in the above Model is null so i get an exception on Model.loginName. any idea whats going on here. If i remove the above code (the validation) everything works fine. (except that i can then put garbage in my database.

Community · Accepted Answer · 2017-05-23 10:27:36Z

4

See my response on a similar topic.

Validating form using ModelState

Every time you add a model error to the ModelState and call the View again, the asp.net MVC framework tries to look for the attempted value. Also your View should return the user_ object to your strongly typed View.

if (user_.firstname.Trim().Length == 0)
{
    ModelState.AddModelError("firstname", "First Name is required.");
    ModelState.SetModelValue("firstname", ValueProvider["firstname"]);

    return View(user_);
}

edited May 23, 2017 at 10:27

CommunityBot

11 silver badge

answered Aug 4, 2009 at 7:29

David

15.4k15 gold badges64 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

RichardOD Over a year ago

There is a similar discussion here- forums.asp.net/p/1377232/2900140.aspx#2900140

ten5peed · Accepted Answer · 2009-08-04 09:02:56Z

1

You're getting a model null error because you're not passing a model to the view... is there anything stopping you from doing just that?

E.g.

if (user_.firstname.Trim().Length == 0)
{
    ModelState.AddModelError("firstname", "First Name is required.");
    return View(user_);
}

Although this should work as a work around... you should really have a good look at how your validation works. Validation should really be done elsewhere other than the controller, for instance, I put all my validation in the model itself.

answered Aug 4, 2009 at 9:02

ten5peed

15.9k3 gold badges62 silver badges74 bronze badges

Comments

sajoshi · Accepted Answer · 2009-08-11 13:40:00Z

1

I added the model in return method and now it started working.

Thanks for the answer.

return View(contactToEdit);

answered Aug 11, 2009 at 13:40

sajoshi

2,7631 gold badge18 silver badges22 bronze badges

Comments

Maxim · Accepted Answer · 2009-08-04 07:32:51Z

0

In your controller you should add overloaded methods:

    public ViewResult UpdateUser()
    {
        return View();
    }

    [AcceptVerbs(HttpVerbs.Post)]
    public ActionResult UpdateUser(user data)
    {
         if (user_.firstname.Trim().Length == 0)
         {
            ModelState.AddModelError("firstname", "First Name is required.");
            return View();
         }
         return View();
    }

With this solution your model in second method will not be null

answered Aug 4, 2009 at 7:32

Maxim

211 silver badge2 bronze badges

Collectives™ on Stack Overflow

asp.net mvc adding validation causes Model to be null

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related