issue fetching data from sqlite android

Question

I have a table having two columns - name and symbol. all i want is to get the symbol corresponding to the name. I use this method. It's kind of returning nothing. Please check this out.

public String getSymbol(String name) {
    String Symbol = "";
    String[] columns = new String[] { "name", "symbol" };
    Cursor c = getReadableDatabase().query(DATABASE_TABLE_NAME, columns, null,
            null, null, null, null);

    int iName = c.getColumnIndex("name");
    int iSymbol = c.getColumnIndex("symbol");

    for (c.moveToFirst(); !c.isAfterLast(); c.moveToNext()) {

        if (c.getString(iName) == name) {
            Symbol = Symbol + c.getString(iSymbol);
        }

    }
    return Symbol;

}

Chirag · Accepted Answer · 2012-09-05 05:49:15Z

1

Try this function.

public String getSymbol(String name)
    {
        try
        {
          String Symbol = "";
          Cursor c = db.query(DATABASE_TABLE_NAME, columns, "name = ?" , new String[] {name}, null, null, null);
          if(c.getCount != 0)
          {
               c.moveToFirst();
               Symbol = String.valueOf(c.getString(c.getColumnIndex("symbol"))); 
               c.close();
               return Symbol;
          }

        }
        catch (Exception e)
        {
            e.printStackTrace();
        }
        return null;
    }

edited Sep 5, 2012 at 5:49

answered Sep 5, 2012 at 5:31

Chirag

56.9k29 gold badges155 silver badges199 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

darsh Over a year ago

Thanks! the code works fine except for this line Symbol = String.valueOf(c.getColumnIndex("symbol")); Actually it should be Symbol = String.valueOf(c.getString(c.getColumnIndex("symbol"))); otherwise it will return the index "1".

darsh Over a year ago

Could you please explain what went wrong in my code. Just to figure out things.

Chirag Over a year ago

You are trying to get all the data and then compare with all data. Its not good idea

Eldhose M Babu · Accepted Answer · 2012-09-05 05:31:23Z

0

Instead of using c.getString(iName) == name while comparing, use c.getString(iName).equalsIgnoreCase(name)

answered Sep 5, 2012 at 5:31

Eldhose M Babu

14.5k8 gold badges41 silver badges44 bronze badges

Collectives™ on Stack Overflow

issue fetching data from sqlite android

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related