Update query in MySQL and PHP not working

Question

PHP usually works pretty much straight out of the box, but I cannot get this query to work. I am attempting to update a simple record. My code is as follows.

<?php

 $customername=mysql_real_escape_string($_POST['customername']); 
 $contact=mysql_real_escape_string($_POST['contact']); 
 $customerorder=mysql_real_escape_string($_POST['customerorder']); 
 $orderplaced=mysql_real_escape_string($_POST['orderplaced']); 
 $staffmember=mysql_real_escape_string($_POST['staffmember']); 
 $daterequired=mysql_real_escape_string($_POST['daterequired']); 
 $status=mysql_real_escape_string($_POST['status']); 
 $paid=mysql_real_escape_string($_POST['paid']); 
 $delivery=mysql_real_escape_string($_POST['delivery']); 
 $ordercontent=mysql_real_escape_string($_POST['ordercontent']); 
 $orderid=mysql_real_escape_string($_GET['orderid']); 

mysql_connect("localhost", "xxxx", "xxxxxxx") or die("Connection Failed");
mysql_select_db("xxxxxx")or die("Connection Failed");


$query = "UPDATE ordermanager_orders SET customername='$customername', contact='$contact',  ordernumber='$customerorder', placedby='$orderplaced', requiredby='$daterequired', status=$status', staffmember='$staffmember', paid='paid', delivery='$delivery', ordercontent='$ordercontent' WHERE order='$orderid'";

if(mysql_query($query)){
 echo "updated";}
 else{
 echo "fail";}

?>

The values are being posted or "Getted" from another page. They are definitely coming through as otherwise it comes up with errors. At the moment it simply comes up with 'failed' as per the code.

I have tried numerous variants of code found on the internet, to check if my coding was correct, however I still cannot get it to work.

There are no error messages showing from mysql, however I'm not sure how to use the echo method to check?? — user1641165
– user1641165, Commented Sep 6, 2012 at 9:46
Always in these cases: echo out your query and copy-and-paste it into a database session (MySQL on the console, or phpMyAdmin). As others have pointed out, you have an error in your SQL. — halfer
– halfer, Commented Sep 6, 2012 at 9:48

Eric T · Accepted Answer · 2012-09-06 09:46:06Z

4

I wonder if u have tried to print_r your $query to check.

1st. Shift your connection string to the top most.

2nd. status=$status' <<=== less 1 quote

answered Sep 6, 2012 at 9:46

Eric T

1,0264 gold badges20 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

472084 · Accepted Answer · 2012-09-06 09:45:45Z

3

I thought you had to connect to the database before you were able to use mysql_real_escape_string()? Try connecting above all other code.

The status section of the query is also missing a quote mark.

answered Sep 6, 2012 at 9:45

472084

17.9k10 gold badges67 silver badges82 bronze badges

4 Comments

user399666 Over a year ago

You're right. You can't use mysql_real_escape_string without a valid connection.

user1641165 Over a year ago

I have pushed the connection to the top of the code, however the same error occurs....

472084 Over a year ago

echo $query and paste it into phpmyadmin to see what it tells you.

user1641165 Over a year ago

Got it sorted, apparently I named one of my columns incorrectly.... no wonder no one here spoted it. Thanks everyone for your help anyhow.... so glad I got this sorted :)

Conrad Lotz · Accepted Answer · 2012-09-06 09:47:12Z

1

Try changing by adding a comma

status=$status' to status='$status'

And FYI change paid='paid' to paid='$paid' to ensure the correct value is passed

answered Sep 6, 2012 at 9:47

Conrad Lotz

8,9533 gold badges25 silver badges28 bronze badges

Comments

halfer · Accepted Answer · 2012-09-06 10:21:28Z

1

Your error is because of not handling your status update correctly: status=$status' must be status='$status'.

You would have figured this if you'd put a mysql_error() in your 'fail' section.

edited Sep 6, 2012 at 10:21

halfer

20.2k20 gold badges110 silver badges207 bronze badges

answered Sep 6, 2012 at 9:45

Ben

11.3k19 gold badges80 silver badges140 bronze badges

1 Comment

user1641165 Over a year ago

I have changed the status problem with no avail

Collectives™ on Stack Overflow

Update query in MySQL and PHP not working

4 Answers 4

Comments

4 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

4 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related