Javascript Changing value of span element

Question

I was trying to change the value of a span with a specific id. Apparently, i am missing something. Here is the code

Javascript:

<script type="text/javascript">
function deis(deistir)
{

                 document.getElementById(deistir).innerHTML=2;

}

</script>

HTML:

<div class="arrow-up"  onClick="deis(<?php echo "cevap_".$id;?>)">
  </div>

    <span style="font-size:30px; color:#333;" id = "<?php echo "cevap_".$id;?>">

  &nbsp;&nbsp;1

 </span>

You may wonder why i am using php for id. It is because html segments in while loop so that $id keeps changing. Why is it not becoming 2? I want to alter the value of span from 1 to 2 when there is a click event.

If your JavaScript doesn't work. Don't show us the PHP. Determine if the output of the PHP is what you expect, and if it is then ask when the JavaScript doesn't work and show us the PHP output. If the output isn't what you expect, then you know you have a PHP problem and you have narrowed down what it is. — Quentin
– Quentin, Commented Sep 6, 2012 at 17:44

Quentin · Accepted Answer · 2012-09-06 17:42:26Z

1

You are passing an (undefined) variable when you want a string literal.

deis(<?php echo "cevap_".$id;?>)"
//   ^  needs quotation marks ^

answered Sep 6, 2012 at 17:42

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user893970 · Accepted Answer · 2012-09-06 17:53:35Z

0

Ok i did:)

I changed this:

<div class="arrow-up"  onClick="deis(<?php echo "cevap_".$id;?>)">

to that

<div class="arrow-up"  onClick="deis('<?php echo "cevap_".$id;?>')">

answered Sep 6, 2012 at 17:53

user893970

8896 gold badges17 silver badges28 bronze badges

1 Comment

Quentin Over a year ago

Yes, that is what I suggested.

Collectives™ on Stack Overflow

Javascript Changing value of span element

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related