jQuery .each loop string or object

Question

Why does this not work?

$( ["blog","user","forum"] ).each(function(num,opt) {
    if ( window.location.pathname.indexOf(opt) != -1 ) {
        $('#rb-' + opt).attr('checked','checked');
        return false;
      }
});

When I input $('#rb-blog').attr('checked','checked'); it works as expected?

console.log(typeof opt) produces string and the expected value.

--- UPDATE ---

I've just seen the html is being written to the page via ajax and is executed on .ready() :( Thanks for the help all, much appreciated.

Your code looks just fine. Are you sure window.location.pathname contains the option? — João Silva
– João Silva, Commented Sep 10, 2012 at 14:19
Is your code in a readyor load block? Your checkboxes may not be initialized yet. — Michael Laffargue
– Michael Laffargue, Commented Sep 10, 2012 at 14:20
Like @ComputerArts mentioned, it should be either an id, type or classname - [".blog",".user",".forum"], or #blog etc.. — karthikr
– karthikr, Commented Sep 10, 2012 at 14:23
Could you please provide also the html code of the web page? — Muffo
– Muffo, Commented Sep 10, 2012 at 14:25

Ties · Accepted Answer · 2012-09-10 14:44:30Z

1

What the problem could be if the page is not fully loaded and #rb-blog is not available yet.

$(document).ready(function(){
    $( ["blog","user","forum"] ).each(function(num,opt) {
        if ( window.location.pathname.indexOf(opt) != -1 ) {
            $('#rb-' + opt).attr('checked','checked');
            return false;
        }
    });
});

edited Sep 10, 2012 at 14:44

answered Sep 10, 2012 at 14:29

Ties

5,8563 gold badges30 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:18:30Z

0

As already noted in the comments, return false will actually exit the "blog", "user", "forum" loop and thus stop checking the checkboxes once one pathname.indexOf condition is true.

Also you might want to add a console.log(window.location.pathname); to make certain this variable contains what you are checking on. Perhaps it is a casing issue?

If you want to know which literals are present in pathname you could use this:

var isPresent = [];
$( ["blog","user","forum"] ).each(function(num,opt) {
    if ( window.location.pathname.indexOf(opt) != -1 ) {
        $('#rb-' + opt).attr('checked','checked');
        isPresent.push(opt);
    }
});

If you just want to know if one of the literals is present in pathname:

var isAtLeastOneIsPresent = false;
$( ["blog","user","forum"] ).each(function(num,opt) {
    if ( window.location.pathname.indexOf(opt) != -1 ) {
        $('#rb-' + opt).attr('checked','checked');
        isAtLeastOneIsPresent = true;
    }
});

edited May 23, 2017 at 12:18

CommunityBot

11 silver badge

answered Sep 10, 2012 at 14:34

Laoujin

10.3k7 gold badges45 silver badges72 bronze badges

1 Comment

Jongosi Over a year ago

Thx, exiting the loop after the first match is the desired behaviour.

Community · Accepted Answer · 2017-05-23 10:24:12Z

Solution: the HTML content was not yet written to the page, so now we wait for ajax requests to complete, then we call the function to update the select value, like so...

// apply checked to the selected element
function setAsChecked() {
    $.each(["blog","user","forum"], function(num,opt){
        if (window.location.pathname.indexOf(opt) != -1) {
            $('#rb-' + opt, '.radio_menu').attr('checked','checked');
            return false;
        }
    });
}

// $('.radio_menu').ajaxStop(function(){
//  setAsChecked();
// });

// UPDATE! ajaxStop() catches all our ajax events - not cool. Instead, use when
$.when( $.ajax("") ).done(function(){
    setAsChecked();
});

Maybe that saves someone else a headache!

--- EDIT ---

BE WARNED! This solution caused a major headache when used with CakePHP. The layout disappeared when we called this function in the footer.

See this thread: CakePHP no layout on back and forward button

Collectives™ on Stack Overflow

jQuery .each loop string or object

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related