Sorting Dynamically With Links in MySQL

Question

I have a MySQL query I'm trying to sort dynamically when a link is clicked.

My link looks like this

                 <form action="topics.php" method="get" class="form">
                   <label class="label">Order Table By</label>
                    <li><a href="topics.php?sort=ID">ID</a></li>
                    <li><a href="topics.php?sort=Title">Title</a></li>
                    <li><a href="topics.php?sort=TAGS">Tags</a></li>
                    <li><a href="topics.php?sort=VIEWS">Views</a></li>
                 </form>

MySQL Query looks like this:

<?php

        $order = mysql_real_escape_string($_GET['sort']);          
$topics = mysql_query("SELECT topic_id AS 'ID', topic_head AS 'Title', 
                              topic_tags AS 'TAGS', topic_views AS 'VIEWS',
                       FROM forum_topics 
                       WHERE topic_id > 0 ORDER BY '$order' DESC") or die (mysql_error());

When I click any of the links above nothing happens. No error is shown, no sorting is done. Where could the problem be ? Thanks

Jelmer · Accepted Answer · 2012-09-11 07:24:12Z

1

Try this:

<?php
  $sortParams = ('ID','Title','Tags','Views');
  $order = mysql_real_escape_string($_GET['sort']);
  if(!in_arrray($order,$sortParams))
  {
    $order = 'ID';//Assuming by default you sorting by ID
  }  
  $topics = mysql_query("SELECT topic_id AS 'ID', topic_head AS 'Title', 
        topic_tags AS 'TAGS', topic_views AS 'VIEWS',
        FROM forum_topics 
        WHERE topic_id > 0 ORDER BY $order DESC") or die (mysql_error());

edited Sep 11, 2012 at 7:24

Jelmer

2,6932 gold badges29 silver badges45 bronze badges

answered Sep 11, 2012 at 7:19

Tarun

3,1754 gold badges33 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Himanshu · Accepted Answer · 2012-09-11 07:12:18Z

1

You are sorting by $_SESSION['order'] and not by $order... I would suggest replacing $_SESSION['order'] with $order or do $_SESSION['order'] = $order before you create your MySQL query.

edited Sep 11, 2012 at 7:12

Himanshu

32.8k32 gold badges117 silver badges137 bronze badges

answered Sep 11, 2012 at 7:10

bkwint

6264 silver badges9 bronze badges

1 Comment

Dot Oyes Over a year ago

Thanks for the answer. I have removed the $_SESSION['order'], but still not working

Jelmer · Accepted Answer · 2012-09-11 07:14:56Z

1

error_reporting(E_ALL);

Add that to your code. http://php.net/manual/en/function.error-reporting.php

If you have a closer look at your code, you can see that you are using $_SESSION[order] instead of $_SESSION['order'] notice the quotes

The true problem is:

At line 1 you defined $order, and not $_SESSION['order'].

My tip is: get a proper IDE, a proper IDE like PhpStorm or Netbeans will highlight a lot of mistakes you made like typos and unused variables. Can become handy when you have problems remembering your variables ;)

answered Sep 11, 2012 at 7:14

Jelmer

2,6932 gold badges29 silver badges45 bronze badges

Comments

Tepken Vannkorn · Accepted Answer · 2012-09-11 07:13:54Z

0

$_SESSION[order] is another variable other than $order. They are different, so that what you have done would not order anything unless you replace your $_SESSION[order] with the variable $order or they share the same value.

answered Sep 11, 2012 at 7:13

Tepken Vannkorn

9,72914 gold badges63 silver badges86 bronze badges

4 Comments

Dot Oyes Over a year ago

I removed $_SESSION['order'] and replaced with $order, but still not working.

Jelmer Over a year ago

@DotOyes, please add it as an update instead of an edit in the original post. For new visitors of this post, a lot of the answers look useless, but they DID help you. So please: ADD instead of EDIT to your original post ;)

Tepken Vannkorn Over a year ago

Assuming that your query is:

$topics = mysql_query("SELECT topic_id AS 'ID', topic_head AS 'Title',                                topic_tags AS 'TAGS', topic_views AS 'VIEWS',                        FROM forum_topics                         WHERE topic_id > 0 ORDER BY '".$order."' DESC") or die (mysql_error());

Tepken Vannkorn Over a year ago

If it still does not work, check your return value. For example, topic_id will return as Integer, and others will return as string values. Then using proper quotes at your $order variable.

Barmar · Accepted Answer · 2012-09-11 07:27:34Z

0

The problem is that you have quotes around $order, so it's sorting by a literal string, not a column. Change them to backquotes.

 WHERE topic_id > 0 ORDER BY `$order` DESC"

answered Sep 11, 2012 at 7:27

Barmar

789k57 gold badges554 silver badges669 bronze badges

Collectives™ on Stack Overflow

Sorting Dynamically With Links in MySQL

5 Answers 5

Comments

1 Comment

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related