MVC3 dropdown list from array

Question

Trying to load a dropdownlist from an array of Countries:

Country[] Countries = ViewBag.mps.GetCountryList(ViewBag.LogonTicket, ViewBag.PID);
/* Country object defined as, returned from WCF webservice call above:
  <xs:complexType name="Country">
  <xs:sequence>
  <xs:element minOccurs="0" name="CountryName" nillable="true" type="xs:string" /> 
  <xs:element minOccurs="0" name="CountryCode" nillable="true" type="xs:string" /> 
  </xs:sequence>
  </xs:complexType>
*/


<select id="BusinessCountry" name="BusinessCountry" class="validate[required]" parentTab="tab4" style="width:160px;">
@{
    foreach(Country c in Countries) {
    <option value="@c.CountryCode" (@ViewBag.BusinessCountry == @c.CountryCode?"selected=\"selected\"":"") >@c.CountryName</option> 
    }
}
</select>

This is the output:

<option af?"selected="\&quot;selected\&quot;&quot;:&quot;&quot;)" (us="=" value="AF">Afghanistan</option>

What am I doing wrong and how can I fix it? I've also tried this but get an exception:

@Html.DropDownList("BusinessCountry", new SelectList(Countries, "CountryCode", "CountryName", @ViewBag.part.BusinessCountry), Countries)

Already figured out how to do it with the code I have:

<select id="BusinessCountry" name="BusinessCountry" class="validate[required]" parentTab="tab4" style="width: 160px;">
@foreach(Country c in Countries) {
  string sel = (ViewBag.part.BusinessCountry == c.CountryCode?"selected=\"selected\"":"");
  <option value="@c.CountryCode" @sel >@c.CountryName</option> 
}
</select>

Shyju · Accepted Answer · 2012-09-12 19:09:08Z

6

Mixing a lot of code in the view is a wrong way to do this. Also usage of ViewBag/ViewData to transfer data like this between action methods and views, makes your code ugly. You should consider a ViewModel to transfer the data from action method to view.

Assuming your view is to create a Company Details, Have a view model like this

public class CompanyViewModel
{
  public string Name { set;get;}
  public IEnumerable<SelectListItem> Countries { set;get;}
  public int SelectedCountry { set;get;}

  CompanyViewModel()
  {
    Countries=new List<SelectListItem>();
  }
}

Now in your GET Action method, you will fill the data to the Countries collection of the viewModel object and send that to the View.

public ActionResult Create()
{
   CompanyViewModel vm=new CompanyViewModel();
   // The below line is hard coded for demo. you may replace 
   //  this with loading data from your Data access layer/ Existing array
   vm.Countries= new[]
   {
      new SelectListItem { Value = "1", Text = "United States" },
      new SelectListItem { Value = "2", Text = "Canada" },
      new SelectListItem { Value = "3", Text = "Australia" }
   };
   return View(vm);
}

Now in your strongly typed view,

@model CompanyViewModel
@using(Html.Beginform())
{
   @Html.DropDownListFor(x => x.SelectedCountry,
                   new SelectList(Model.Countries,"Value","Text"), "Select..")
   <input type="submit" />

}

Now in your HTTPPost method, you will get the Selected country id by accessing the SelectecCountry Properties value of the Model posted

[HttpPost]
public ActionResult Create(CompanyViewModel model)
{
  if(ModelState.IsValid)
  {
      //check for model.SelectedCountry property value here
      //Save and Redirect
  }
  //Reload countries here
  return View(model);
}

answered Sep 12, 2012 at 19:09

Shyju

220k106 gold badges420 silver badges499 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Gromer Over a year ago

This is the only way I would do this. +1

MB34 Over a year ago

While I accept you chastising, I have already figured out how to do it and updated the code above.

user1477388 · Accepted Answer · 2012-09-12 18:45:59Z

0

I use dropdown list like this:

In Controller:

ViewBag.CompanyId = New SelectList(db.Companies, "CompanyId", "Name", blog.CompanyId)

In View:

<div class="editor-field">
    @Html.DropDownList("CompanyId", String.Empty)
    @Html.ValidationMessageFor(Function(model) model.CompanyId)
</div>

Note: This is VB.

answered Sep 12, 2012 at 18:45

user1477388

21.6k35 gold badges152 silver badges277 bronze badges

Comments

STO · Accepted Answer · 2012-09-12 18:49:41Z

0

Try this code for attribute

@((ViewBag.BusinessCountry == @c.CountryCode) ? "selected='selected'" : "")

answered Sep 12, 2012 at 18:49

STO

10.7k8 gold badges34 silver badges32 bronze badges

Collectives™ on Stack Overflow

MVC3 dropdown list from array

Already figured out how to do it with the code I have:

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

Already figured out how to do it with the code I have:

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related