JavaScript code issue : I am converting object to array

Question

I am converting JavaScript object to array but in result I am getting one null

here my code

<div id="a"></div>

Object.prototype.toArray = function(){
    var arr = [];
    for (var i in this) {
        arr.push(this[i]);        
    }
    return arr;
} 

var providers = {
            facebooklike: "Facebook Like",
            facebookrecommend : "Facebook Recommend",
            facebooksend : "Facebook Send",
            twittertweet : "Twitter Tweet",
            linkedinshare : "LinkedIn Share",
            linkedinrecommend : "LinkedIn Recommend",
            googleplusplusone : "Google+ +1",
            googleplusshare : "Google+ Share"
        };

var a = document.getElementById("a");
a.innerHTML = JSON.stringify(providers.toArray());

My result is

["Facebook Like","Facebook Recommend","Facebook Send","Twitter Tweet","LinkedIn Share","LinkedIn Recommend","Google+ +1","Google+ Share",null]

Here is fiddle example

IUnknown · Accepted Answer · 2012-09-13 09:53:55Z

4

Add check for own properties (not inherited from the Object proptotype):

Object.prototype.toArray = function(){
    var arr = [];
    for (var i in this) {
        if(this.hasOwnProperty(i))
            arr.push(this[i]);        
    }
    return arr;
}

answered Sep 13, 2012 at 9:53

IUnknown

22.5k4 gold badges41 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

xdazz · Accepted Answer · 2012-09-13 09:53:32Z

3

Add hasOwnProperty check.

for (var i in this) {
    if (this.hasOwnProperty(i)) {
        arr.push(this[i]);
    }        
}

answered Sep 13, 2012 at 9:53

xdazz

161k38 gold badges255 silver badges278 bronze badges

2 Comments

Govind Malviya Over a year ago

can you tell me why it is getting extra property in for in loop

xdazz Over a year ago

@GovindKamalaPrakashMalviya And you should know the null comes from the key toArray, and the last element in the result array is a function, which caused null when do JSON.stringify :)

Collectives™ on Stack Overflow

JavaScript code issue : I am converting object to array

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related