How to declare javascript variables a different way

Question

How to declare variables this way:

var sarr = $("#crop_vals").find("input");
$(sarr).each(function() { 
    var $(this).attr("id") = $(this).val();
});

What I want is to have var named the id equivalent to the value.

You shouldn't do it but I'll say anyway; window[ $(this).attr("id") ] = $(this).val();, with no var statement. — Paul S.
– Paul S., Commented Sep 15, 2012 at 14:13
+1. it is a valid question. The way you have it written though is invalid code. Running JSLint over it for example results in Bad assignment. var $(this).attr("id") = $(this).val(); Using your existing code, the least amount of change to your coude to fix the issue would be $(this).attr("id", $(this).val()); — Nope
– Nope, Commented Sep 15, 2012 at 14:16
Added an answer as all the other answers interpreted your question as "How do I set an ID?", whereas I read it as "How do I create a variable with the same name as the ID and set it to the value of the element with said ID?" — Paul S.
– Paul S., Commented Sep 15, 2012 at 14:25
@Squirkle You could at least read a educational book like "Eloquent Javascript" to actually know what you're doing in practice. OP check out eloquentjavascript.net — Markus Unterwaditzer
– Markus Unterwaditzer, Commented Sep 15, 2012 at 14:46

Ram · Accepted Answer · 2012-09-15 14:25:06Z

5

You cannot set the attribute of an element that way, you are getting a value.

var $sarr = $("#crop_vals").find("input");

$sarr.each(function() { 
    this.id = this.value;
})

Note that as you have cached the objects, there is no need to use $() again.

Setting an attribute:

$(selector).attr('id', 'newValue');

Getting an attribute:

var id = $(selector).attr('id');

You can also use attr callback function:

$sarr.attr('id', function() { 
    return this.value;
})

edited Sep 15, 2012 at 14:25

answered Sep 15, 2012 at 14:07

Ram

145k16 gold badges174 silver badges201 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Paul S. · Accepted Answer · 2012-09-15 14:20:27Z

1

To set the "variables" globally (though you shouldn't do this because it's asking for trouble)

var sarr = $("#crop_vals").find("input");
$(sarr).each(function() { 
    window[ this.id ] = this.value;
});

To set them in a safer way, you could do

var sarr = $("#crop_vals").find("input"),
    myVars = {};
$(sarr).each(function() { 
    myVars[ this.id ] = this.value;
});

and access with myVars[ id ].

answered Sep 15, 2012 at 14:20

Paul S.

66.6k9 gold badges130 silver badges143 bronze badges

Comments

Adil · Accepted Answer · 2012-09-15 14:15:49Z

1

You have wrong syntax for assigning value to attribute, you need to use attr('attributeName', 'value');

Change

var $(this).attr("id") = $(this).val();

To

$(this).attr("id", $(this).val());

You code will be

var sarr=$("#crop_vals").find("input");
$(sarr).each(function(){ 
     $(this).attr("id",$(this).val());
});

edited Sep 15, 2012 at 14:15

answered Sep 15, 2012 at 14:05

Adil

148k25 gold badges217 silver badges207 bronze badges

7 Comments

Squirkle Over a year ago

var $(this).attr("id",$(this).val()); uhh what?

David G Over a year ago

Be sarcastic in the comments, not the answers.

Adil Over a year ago

I have updated my answer, There was problem in assignment of id.

Squirkle Over a year ago

Then don't just copy the code from the OP, and dump it into your answer without editing it :)

Adil Over a year ago

@Squirkle thanks for your suggestion but copy is one of the feature that is very difficult to avoid and useful most of times.

|

Collectives™ on Stack Overflow

How to declare javascript variables a different way

3 Answers 3

Comments

Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related