Create several MySQL tables from a loop?

Question

This is the code:

<?php
$months= array("january", "november", "december");
$db_server = include('root.php');
if (!$db_server) die("Unable to connect to MySQL: " . mysql_error());
mysql_select_db('info');
for ($i=0; $i < $months; $i++){
    $query1 = "CREATE TABLE {$months[$i]} (
    StIDf CHAR(10) NOT NULL, FulNam TEXT NOT NULL, ComNam TEXT NOT NULL,Add TEXT ,Tel TEXT )";
}
?>

But it's not working. I need to create several tables from one loop. Is it possible to do that?

Please don't do that. Just have one table and add an extra column for the month. — Mark Byers
– Mark Byers, Commented Sep 16, 2012 at 17:33
my table is really big to type and it makes the coding so big so i thought to make a table via loop — sadpcd201209
– sadpcd201209, Commented Sep 25, 2012 at 16:56

Nikolaos Dimopoulos · Accepted Answer · 2012-09-16 17:35:22Z

1

Try this:

<?php
$months    = array("january","november","december");
$db_server = include('root.php');

if (!$db_server) die("Unable to connect to MySQL: " . mysql_error());

mysql_select_db('info');

foreach($months as $month) {
    $query1 = "CREATE TABLE {$month}  ( "
            . "StIDf CHAR(10) NOT NULL, "
            . "FulNam TEXT NOT NULL, "
            . "ComNam TEXT NOT NULL, "
            . "Add TEXT, "
            . "Tel TEXT "
            . ")";
    $result = mysql_query($query1);
}
?>

Your code was not executing the mysql_query (or the alternatives from mysqli or PDO) so nothing was executed in the database.

answered Sep 16, 2012 at 17:35

Nikolaos Dimopoulos

11.5k6 gold badges41 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2023-11-17 20:16:56Z

1

You are never performing the actual query, add this line to inside the for-loop:

mysql_query($query1);

Also, you should use count($month) to find out how many items it contains.

for ($i = 0; $i < count($months); $i++) {
    $query1 = "CREATE TABLE {$months[$i]}  (
    StIDf CHAR(10) NOT NULL,FulNam TEXT NOT NULL, ComNam TEXT NOT NULL,Add TEXT ,Tel TEXT )";
    mysql_query($query1);
}

Also, I suggest using mysqli or mysql PDO instead of the old, will be deprecated in the future, mysql API. Read more about that here: https://www.php.net/manual/en/mysqlinfo.api.choosing.php

edited Nov 17, 2023 at 20:16

CommunityBot

11 silver badge

answered Sep 16, 2012 at 17:29

Simon Forsberg

13.4k11 gold badges66 silver badges109 bronze badges

1 Comment

sadpcd201209 Over a year ago

i was just started php i'll try mysqli

Collectives™ on Stack Overflow

Create several MySQL tables from a loop?

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related