Java - Two different @ModelAttribute on the same view takes up same values

Question

This is probably a very simple error somewhere. Please help. I have a home.jsp page with two <form:form> tags:

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

<%@ taglib uri="/META-INF/c.tld" prefix="c"%>
<%@ taglib uri="/META-INF/fmt.tld" prefix="fmt"%>
<%@ taglib uri="/META-INF/spring-form.tld" prefix="form"%>

<html>

<meta http-equiv="Content-Type" content="text/html;charset=UTF-8">

<head>
    <title>Home Page</title>
</head>

<body>

<div>
    <form:form name="loginForm" modelAttribute="loginUser" action="login" method="post">

        <c:if test="${loginMsg != null}"><c:out value="${loginMsg}"></c:out></c:if>
        <br/>

        Email: <form:input name="loginEmail" id="loginEmail" value=""   path="email"/>
        <form:errors path="email" cssClass="error" />
        <br/>

        password: <form:password name="loginPassword" Id="loginPassword" value="" path="password" />
        <form:errors path="password" />
        <br/>

        <input type="submit" id="id_login" value="Login">

    </form:form>
</div>

<div>
    <form:form name="SignUpForm" modelAttribute="signUpUser" action="signup" method="post">

        <c:if test="${signupMsg != null}"><c:out value="${signupMsg}"></c:out></c:if>   
        <br/>

        Full Name: <form:input name="name" id="name" value=""   path="name"/>
        <form:errors path="name" cssClass="error" />
        <br/>

        Email: <form:input name="signupEmail" id="signupEmail" value="" path="email"/>
        <form:errors path="email" cssClass="error" />
        <br/>

        password: <form:password name="signUpPassword" Id="signUpPassword" value="" path="password" />
        <form:errors path="password" />
        <br/>

        <input type="submit" id="id_signUp" value="Sign Up">

    </form:form>
</div>

</body>

</html>

Each form is handled by a different controller. The problem is, when I fill (just) one of the forms and click the submit button, both the ModelAttributes are getting populated with the same value

There's nothing special to my controllers:

@RequestMapping("/login")
public String login(@ModelAttribute("loginUser") User user,
        BindingResult result, @ModelAttribute("signUpUser") User signUpUser,
        BindingResult signUpResult, ModelMap model, HttpServletRequest request,
        HttpServletResponse response) {

    // Here, both user and signUpUser have the same value (WHY?)
    // But I dint fill the sign up form at all

    loginFormValidator.validate(user, result);

    if(Errors in `result`)
        return "forward:/home";

    // Authentication Logic
    request.getSession().setAttribute("s_user_obj", some_variable);
    return "forward:/home";

}

UPDATE:

Here's the HTMLs generated. BEFORE login action:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

<html>

<meta http-equiv="Content-Type" content="text/html;charset=UTF-8">

<head>
    <title>Welcome to m0m0</title>
</head>

<body>

<div>
    <form id="loginUser" name="loginForm" action="login" method="post">

        <br/>                           
        Email: <input id="loginEmail" name="email" name="loginEmail" type="text" value=""/>

        <br/>
        password: <input id="password" name="password" name="loginPassword" Id="loginPassword" type="password" value=""/>

        <br/>
        <input type="submit" id="id_login" value="Login">

    </form>
</div>

<div>
    <form id="signUpUser" name="SignUpForm" action="signup" method="post">

        <br/>
        Full Name: <input id="name" name="name" name="name" type="text" value=""/>

        <br/>                   
        Email: <input id="signupEmail" name="email" name="signupEmail" type="text" value=""/>

        <br/>
        password: <input id="password" name="password" name="signUpPassword" Id="signUpPassword" type="password" value=""/>

        <br/>
        <input type="submit" id="id_signUp" value="Sign Up">

    </form>
</div>

</body>

</html>

AFTER login action:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

<html>

<meta http-equiv="Content-Type" content="text/html;charset=UTF-8">

<head>
    <title>Welcome to m0m0</title>
</head>

<body>

<div>
    <form id="loginUser" name="loginForm" action="login" method="post">

        <br/>                           
        Email: <input id="loginEmail" name="email" name="loginEmail" type="text" value="[email protected]"/>

        <br/>
        password: <input id="password" name="password" name="loginPassword" Id="loginPassword" type="password" value=""/>

        <br/>
        <input type="submit" id="id_login" value="Login">

    </form>
</div>

<div>
    <form id="signUpUser" name="SignUpForm" action="signup" method="post">

        <br/>
        Full Name: <input id="name" name="name" name="name" type="text" value=""/>

        <br/>                   
        Email: <input id="signupEmail" name="email" name="signupEmail" type="text" value="[email protected]"/>

        <br/>
        password: <input id="password" name="password" name="signUpPassword" Id="signUpPassword" type="password" value=""/>

        <br/>
        <input type="submit" id="id_signUp" value="Sign Up">

    </form>
</div>

</body>

</html>

It looks like a bug but I will like to look further. Can you please post the HTML that is generated from this JSP. — Subir Kumar Sao
– Subir Kumar Sao, Commented Sep 18, 2012 at 5:08
@subirkumarsao I've update the question with the HTMLs. Thanks in advance — th3an0maly
– th3an0maly, Commented Sep 18, 2012 at 5:49

marco.eig · Accepted Answer · 2012-09-18 11:43:09Z

2

spring binds the parameters to both models, because it doesn't consider the model name for binding (and btw. there's no information about the model name in the request)

Each form is handled by a different controller.

but this method handles both?

@RequestMapping("/login")
public String login(@ModelAttribute("loginUser") User user,
    BindingResult result, @ModelAttribute("signUpUser") User signUpUser,
    BindingResult signUpResult, ModelMap model, HttpServletRequest request,
    HttpServletResponse response) {

// Here, both user and signUpUser have the same value (WHY?)
// But I dint fill the sign up form at all

loginFormValidator.validate(user, result);

if(Errors in `result`)
    return "forward:/home";

// Authentication Logic
request.getSession().setAttribute("s_user_obj", some_variable);
return "forward:/home";

}

EDIT:

public class Form {
    private User loginUser;
    private User signupUser;
    .....
}

then you can do the following

<form:input path="loginUser.name" />

and

<form:input path="signupUser.name" />

in this case you'll only have 1 model attribute, not 2

edited Sep 18, 2012 at 11:43

answered Sep 18, 2012 at 7:24

marco.eig

4,2292 gold badges21 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

th3an0maly Over a year ago

I dont understand what you mean by "it doesn't consider the model name for binding" and "there's no information about the .." I have provided ModelMap model as an argument to login() To your second question: No, there's another method called SignUp() that handles the sign up form. Initially, each method had only one (relevant) @ModelAttribute. I have modified login() to include signUpUser to demonstrate that both signUpUser and user have the same values in their fields.

marco.eig Over a year ago

spring cannot distinguish between singup form and login form, since both are of type user. the model attribute name is not part of the request body when submitting the form. so it's up to you whether to treat it as a login model or a signup model. spring won't take care of this.

th3an0maly Over a year ago

is there a way I can do something like path="loginUser.name" so that Spring knows which @ModelAttribute it's dealing with? Please refer to the second answer in this post: stackoverflow.com/questions/12230216/…

marco.eig Over a year ago

create 2 form:form elements (like in your post), in the first you can use path prefix "loginUser." and in the second "signupUser."

marco.eig Over a year ago

let us continue this discussion in chat

|

Collectives™ on Stack Overflow

Java - Two different @ModelAttribute on the same view takes up same values

1 Answer 1

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related