Why does following C++ program print string's ascii values instead of characters?

Question

This program is supposed to store each word given in standard input stream and count their occurences. The results are supposed to be printed afterwards in order followed by their count. As far as I can tell, the program is working otherwise, but the strings are printed as a ASCII values of the characters instead of the characters themselves. What's wrong?

#include <iostream>
#include <string>
#include <sstream>
#include <vector>
#include <cctype>
#include <algorithm>

std::string get_word();

int main()
{
    std::vector<std::string> words;
    std::string word;

    while (std::cin.good()) {
        word = get_word();

        if (word.size() > 0)
            words.push_back(word);
    }

    std::sort(words.begin(), words.end());

    unsigned n, i = 0;

    while (i < words.size()) {
        word = words[i];
        n = 1;

        while (++i < words.size() and words[i] == word)
            ++n;

        std::cout << word << ' ' << n << std::endl;
    }
}


std::string get_word()
{
    while (std::cin.good() and !std::isalpha(std::cin.peek()))
        std::cin.get();

    std::stringstream builder;

    while (std::cin.good() and std::isalpha(std::cin.peek()))
        builder << std::cin.get();

    return builder.str();
}

"and" is just another way of writing &&, should work on any modern compiler — user1685094
– user1685094, Commented Sep 20, 2012 at 7:19
Coool. Thanks all for pointing this out. Is && still preferred, though? This is really the first time I've ever seen it in code. — nneonneo
– nneonneo, Commented Sep 20, 2012 at 7:25
@nneonneo: The answer to your question can be found here, they shouldn't be used and basically they exist for keyboards that didn't have &, etc. — Jesse Good
– Jesse Good, Commented Sep 20, 2012 at 7:35

jrok · Accepted Answer · 2012-09-20 07:25:28Z

6

std::istream::get() doesn't return a char but std::ios::int_type (a typedef for some integer type that can hold all values of char_type and EOF) and that is what you insert in stringstream. You should cast the result to char.

std::basic_istream::get

edited Sep 20, 2012 at 7:25

answered Sep 20, 2012 at 7:19

jrok

55.5k10 gold badges114 silver badges146 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Why does following C++ program print string's ascii values instead of characters?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related