Javascript push() method not working aside jQuery inArray()

Question

I am trying to add values to a simple array, but I can't get the values pushed into the array.

So far so good, this is the code I have:

codeList = [];

jQuery('a').live(
    'click', 
    function()
    {
         var code = jQuery(this).attr('id');
         if( !jQuery.inArray( code, codeList ) ) {
              codeList.push( code );
              // some specific operation in the application
         }   
    }
);

The above code doesn't work! But if I manually pass the value:

codeList = [];

jQuery('a').live(
    'click', 
    function()
    {
         var code = '123456-001'; // CHANGES HERE
         if( !jQuery.inArray( code, codeList ) ) {
              codeList.push( code );
              // some specific operation in the application
         }   
    }
);

It works!

I can't figure out what's going on here, because if I do other tests manually it also work!

Include the HTML. I am quite sure that is where the problem lies. — iambriansreed
– iambriansreed, Commented Sep 21, 2012 at 16:02
Starting an ID with a digit is invalid if you're using XHTML or a doctype prior to HTML5. — Fabrício Matté
– Fabrício Matté, Commented Sep 21, 2012 at 16:03

Sushanth -- · Accepted Answer · 2012-09-21 16:15:50Z

4

Try this .. Instead of cheking for bool check for its index.. It returns a -1 when it is not found..

var codeList = [];

jQuery('a').live(
    'click', 
    function()
    {
         var code = '123456-001'; // CHANGES HERE
         if( jQuery.inArray( code, codeList ) < 0) { // -ve Index means not in Array
              codeList.push( code );
              // some specific operation in the application
         }   
    }
);

edited Sep 21, 2012 at 16:15

answered Sep 21, 2012 at 16:07

Sushanth --

55.8k9 gold badges70 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fabrício Matté · Accepted Answer · 2012-09-21 16:18:44Z

3

jQuery.inArray returns -1 when the value is not found, also .live is deprecated on jQuery 1.7+ and you're missing a var statement in your codeList declaration. Here's a rewrite of your code:

//without `var`, codeList becomes a property of the window object
var codeList = [];

//attach the handler to a closer ancestor preferably
$(document).on('click', 'a', function() {
    //no need for attributes if your ID is valid, use the element's property
    var code = this.id;
    if ($.inArray(code, codeList) === -1) { //not in array
        codeList.push(code);
    }
});

Fiddle

And as I stated in the question comments, IDs starting with a digit are illegal unless you're using the HTML5 doctype.

edited Sep 21, 2012 at 16:18

answered Sep 21, 2012 at 16:09

Fabrício Matté

70.3k27 gold badges135 silver badges168 bronze badges

3 Comments

Gilberto Albino Over a year ago

I am not using var because it is a global variable

Fabrício Matté Over a year ago

@GilbertoAlbino Declare it in the global context then. It's good practice to use the var keyword even then. Without any var statement, your code won't pass JSHint/Lint, generate errors in strict mode and codeList will be created as a property of window object without the DontDelete attribute flag.

Fabrício Matté Over a year ago

Of course, if you already have it declared in the global context with a var statement, ignore the comment above.

Collectives™ on Stack Overflow

Javascript push() method not working aside jQuery inArray()

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related