Why does this jquery .css line not work within 2 functions?

Question

this simple jquery .css statement does not activate within two functions, am I doing something wrong?

javascript:

function updateAllCSS(element, property, value) {

    function updateThemeCreatorCSS(element, property, value) {
        $(element).css(property, value)
    }
    updateThemeCreatorCSS(element, property, value)
}
}

updateAllCSS('h1', 'backgroundColor', '#f00')

HTML:

<h1>Test header</h1>

You need to quote your strings when you call updateAllCSS. — gen_Eric
– gen_Eric, Commented Sep 21, 2012 at 17:01

thewebguy · Accepted Answer · 2012-09-21 18:30:34Z

4

This should work:

function updateAllCSS(element, property, value) {
    function updateThemeCreatorCSS(element, property, value) {
        $(element).css(property, value)
    }
    updateThemeCreatorCSS(element, property, value);
}

updateAllCSS('h1', 'background-color', '#f00');

There was an extra } and the parameters being passed to updateAllCSS needed to have 'quotes'.

edited Sep 21, 2012 at 18:30

answered Sep 21, 2012 at 17:04

thewebguy

1,51910 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gen_Eric Over a year ago

It works as backgroundColor as well. Hyphenated CSS properties can be referenced as camelCase in JavaScript.

j08691 · Accepted Answer · 2012-09-21 17:04:09Z

3

You had an extra } and you should quote your parameters.

jsFiddle example

function updateAllCSS(element, property, value) {
    function updateThemeCreatorCSS(element, property, value) {
        $(element).css(property, value)
    }
    updateThemeCreatorCSS(element, property, value);
}
updateAllCSS('h1', 'backgroundColor', '#f00');

answered Sep 21, 2012 at 17:04

j08691

208k33 gold badges269 silver badges281 bronze badges

Comments

Gromer · Accepted Answer · 2012-09-21 17:03:46Z

2

Not sure why you have that nested function. Here's a Fiddle of it working:

http://jsfiddle.net/cbbdW/

answered Sep 21, 2012 at 17:03

Gromer

9,9614 gold badges36 silver badges55 bronze badges

Collectives™ on Stack Overflow

Why does this jquery .css line not work within 2 functions?

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related