JavaFX Nested Controllers (FXML <include>)

Question

In this tutorial, there is an example of how to include custom components and use their controllers from the controller of the container.

main_window_content.fxml

<VBox fx:controller="com.foo.MainController">
   <fx:include fx:id="dialog" source="dialog.fxml"/>
   ...
</VBox>

MainController.java

public class MainController extends Controller {
    @FXML private Window dialog;
    @FXML private DialogController dialogController;

    ..

If the component is included only once, it works fine. If the same component is included twice, the controllers are not initialized. Both controllers are null.

main_window_content.fxml

    <VBox fx:controller="com.foo.MainController">
       <fx:include fx:id="dialog1" source="dialog.fxml"/>
       <fx:include fx:id="dialog2" source="dialog.fxml"/>
       ...
    </VBox>

MainController.java

    public class MainController extends Controller {
        @FXML private Window dialog1;
        @FXML private DialogController dialogController1;
        @FXML private Window dialog2;
        @FXML private DialogController dialogController2;

Could someone help me to solve the problem? Thanks

This is my FXML loading code. It is executed in the main application method:

public void start(Stage stage) throws Exception { 
    Parent root = FXMLLoader.load(getClass().getResource("main_window_content.fxml"));
    stage.setTitle("FXML Welcome"); 
    stage.setScene(new Scene(root, 300, 275));
    stage.show(); 
}

The second answer is the right solution for this question, It should be marked "Accepted" — Amir Arad
– Amir Arad, Commented Aug 16, 2014 at 11:31

fabian · Accepted Answer · 2015-12-18 17:23:57Z

43

Thanks to Daniel (from OTN) I found the error in my code, the names of my controller variables were wrong. They should be <fx:id>Controller. In other words it should be:

MainController.java

public class MainController extends Controller {
@FXML private Window dialog1;
@FXML private DialogController dialog1Controller;
@FXML private Window dialog2;
@FXML private DialogController dialog2Controller;

But studying the changes introduced in version 2.2 I found that everything can be easily solved by using <fx:root> tag (like this tutorial). I entered my component in FXML simply declaring it like this:

<HBox>
    <Dialog id="dialog1" text="Hello World!"/>
    <Dialog id="dialog2" text="Hello World!"/>
</HBox>

I hope to be helpful

edited Dec 18, 2015 at 17:23

fabian

82.9k12 gold badges99 silver badges124 bronze badges

answered Sep 24, 2012 at 20:31

Antonello

4313 silver badges2 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Coral Doe Over a year ago

Also, mark your own answer as accepted, to make it more visible as the solution to your problem. Just click the tick next to this answer.

fabian · Accepted Answer · 2015-12-18 17:21:52Z

2

There seems to be a bug in netbeans 8.0 with nested fxmls as well. Cannot count on netbeans to create the nested fxml's controller object for you, it has to be manually inserted into your MainController. Every time the controller is updated in netbeans it gets wiped out so it can be kind of tedious. For this example that would be inserting the

@FXML private DialogController dialog1Controller;

line manually into the main controller in this case, then it works normally. Very useful for organizing large fxmls/controllers.

edited Dec 18, 2015 at 17:21

fabian

82.9k12 gold badges99 silver badges124 bronze badges

answered Jun 24, 2014 at 13:22

SamHuman

1868 bronze badges

Collectives™ on Stack Overflow

JavaFX Nested Controllers (FXML <include>)

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related