Send multiple shell commands with app

Question

Ok I'm learning how shell commands work, so I decided to develop a app to send the commands. This is what I got.

moveDirectory.setOnClickListener(new OnClickListener(){
    public void onClick(View v)
    {
        try{
            Process send = Runtime.getRunetime().exec(new String[] {"cd /sdcard/music/", "cp pic1 /sdcard/pic1"});
            send.waitFor();
        } catch (Exception ex){
            String toast = null;
            Log.i(toast, "Couldn't copy file", ex);
            }
        }
    });

But it isn't working, the first command is working, but not the second one. What should I add to it?

Thanks

EDIT: forgot to add the send.waitFor(); line

Didn't know that I need permissions, which ones should I need? and if its a permission problem, why it changes the directory to /sdcard/music/, but it doesn't copy the file? — Rotary Heart
– Rotary Heart, Commented Sep 28, 2012 at 6:45

Laser · Accepted Answer · 2012-09-28 06:49:22Z

3

Use normal command delimeter ;

moveDirectory.setOnClickListener(new OnClickListener(){
    public void onClick(View v)
    {
        try{
            Process send = Runtime.getRunetime().exec(new String[] {"cd /sdcard/music/ ; cp pic1 /sdcard/pic1"});
        } catch (Exception ex){
            String toast = null;
            Log.i(toast, "Couldn't copy file", ex);
            }
        }
    });

In this code you
1) go to the /sdcard/music
2) copy from /sdcard/music pic1 to /sdcard/pic1

answered Sep 28, 2012 at 6:49

Laser

7,0308 gold badges56 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Rotary Heart Over a year ago

OMG, can't believe that it was so simple... thank you very much this did the trick, last question: Can I add as much as I want?

Laser Over a year ago

yes but all must be saparate with ; - symbol. Also more about bash you can find here gnu.org/software/bash/manual/bashref.html

Rotary Heart Over a year ago

Awesome link, this will keep me reading for a few days. Thank you very much!

Marius Kjeldahl · Accepted Answer · 2012-09-28 06:52:12Z

0

I'm speculating, but you may have misunderstood what the parameter to exec really is. It's not a list of commands to be executed (effectivly a batch/shell script), but a single command WITH it's arguments to be executed by a shell. Making it a one-liner like Pepelac suggests or putting the series of commands into a single file that you execute with exec later may be what you are looking for. For the command you are trying to execute there is absolute no reason why you can not make it a one-liner with the full source path included (instead of changing to it), but there may be other reasons why you need to do this that you have not mentioned.

answered Sep 28, 2012 at 6:52

Marius Kjeldahl

6,8243 gold badges37 silver badges37 bronze badges

Collectives™ on Stack Overflow

Send multiple shell commands with app

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related