ASP.NET MVC Custom Validation in View Model Best Practice

Question

I am trying to use a combination of Domain Driven Design with Test Driven Development for this application I am building in ASP.NET MVC 3. My archictecture is set up with Repositories, Domain Models, View Models, Controllers and Views. All validation will be handled in the view model. I set up my view model to inherit from "IValidatableObject" so that my validation attributes and my custom validation that i set up in the "Validate" method are both executed when my controller method calls "ModelState.IsValid". The problem I am running into is accessing my repository in the Validate method of my view model. I need to access the repository to check for duplicate records in the database. It seems like the best idea would be to create a property of IRepository type and set that property by passing injecting my repository into the constructor of the view model. For example:

public class UserViewModel : IValidatableObject
{
       public UserViewModel(User user, IUserRepository userRepository)
       {
              FirstName = user.FirstName;
              LastName = user.LastName;
              UserRepository = userRepository;
              UserName = user.UserName;
       }
       public string UserName { get; set; }
       public string FirstName { get; set; }
       public string LastName { get; set; }
       public IUserRepository UserRepository { get; set; }
       public IEnumerable<ValidationResult> Validate()
       {
           UserCriteria criteria = new UserCriteria { UserName = this.UserName };
           IList<User> users = UserRepository.SearchUsers(criteria);

           if (users != null && users.count() > 0)
           {
               yield return new ValidationResult("User with username " + this.UserName + " already exists."
           }
       }
}

Do you guys think this is a good idea?

Personally I would avoid having a property that performs a database lookup. — Justin Helgerson
– Justin Helgerson, Commented Sep 28, 2012 at 18:41
I see what you're saying, but how else would I validate against duplicate records. I was thinking about creating a custom validation method that the controller method would call and pass in the modelstate. The method would then perform my custom validations and add the model errors to the modelstate (side effect- c# object = pass by reference), but it seems like what i posted would be alot cleaner and code would be simpler. — RiceRiceBaby
– RiceRiceBaby, Commented Sep 28, 2012 at 18:50
The Domain Validation must be encapsulated in the domain. Validation is a concept that must be applied at several places in the application. Typically when you validate a View-Model, you are validating to check that the data provided by the user is safe, (apply sanitizer) and apparently correct. Then you usually would call your aggregate root to perform some actions. There you should validate the domain invariants (domain rules). In a CQRS architecture, I have found it's a good practice to validate inside the CommandHandler — Jupaol
– Jupaol, Commented Sep 28, 2012 at 18:54

Jupaol · Accepted Answer · 2012-09-28 18:56:17Z

2

It is good enough but if I were you, I would use

...
private readonly Func<IUserRepository> userRepositoryFactory;
...
public IEnumerable<ValidationResult> Validate()  
   {  
       UserCriteria criteria = new UserCriteria { UserName = this.UserName };  
       using(var UserRepository = userRepositoryFactory())
       {
           IList<User> users = UserRepository.SearchUsers(criteria);  

           if (users != null && users.count() > 0)  
           {  
               yield return new ValidationResult("User with username " + this.UserName + " already exists."  
           }  
       }
   }

edited Sep 28, 2012 at 18:56

Jupaol

21.4k9 gold badges71 silver badges101 bronze badges

answered Sep 28, 2012 at 18:54

Kirill Bestemyanov

12k2 gold badges26 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

RiceRiceBaby Over a year ago

In your first post, it sounds like I shouldn't follow this approach. It seems like you are saying I should only put business logic validation in the domain.

Aditya Nagodra · Accepted Answer · 2012-09-28 19:30:46Z

0

You can add Domain Service class to get object match with your criteria and validated at domain service level

 public class PurchaseOrder
    {
        public string Id { get; private set; }
        public string PONumber { get; private set; }
        public string Description { get; private set; }
        public decimal Total { get; private set; }
        public DateTime SubmissionDate { get; private set; }
        public ICollection<Invoice> Invoices { get; private set; }

        public decimal InvoiceTotal
        {
            get { return this.Invoices.Select(x => x.Amount).Sum(); }
        }

    }

    public class PurchaseOrderService
    {
        public PurchaseOrderService(IPurchaseOrderRepository repository)
        {
            this.repository = repository;
        }

        readonly IPurchaseOrderRepository repository;

        public void CheckPurchasedOrderExsist(string purchaseOrderId)
        {
                var purchaseOrder = this.repository.Get(purchaseOrderId);
                if (purchaseOrder != null)
                    throw new Exception("PO already exist!");
        }
    }

edited Sep 28, 2012 at 19:30

answered Sep 28, 2012 at 19:25

Aditya Nagodra

12 bronze badges

2 Comments

RiceRiceBaby Over a year ago

It seems like you are saying, I should validate my form in the view model, but business logic validation should go in the domain or service which makes sense. The question is, how would i send validation errors back to the modelstate in the controller?

Aditya Nagodra Over a year ago

you can do this by throwing exception from domain model and catch that in view because as per DDD your domain model should be isolated from your infrastructure logic...

Collectives™ on Stack Overflow

ASP.NET MVC Custom Validation in View Model Best Practice

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related