Javascript Regex Match()

Question

I just want this function to return an int back based on a string but its not working It will be either H or V followed by 1 or 2 digits.

IE: H1         return 99
    H09        return 91
    H10        return 90
    H50        return 50
    V1         return 1
    V05        return 5
    V11        return 11
    V50        return 50

spot will be my string thats going in.

get100YardVersionEugene: function(spot)
{
        var team = spot.match(/[A-Z]+/);
        var yard = spot.match(/([0-9]+)/);

        if (team == "H")
        {
            return 100-yard;
        }
        else //V
        {
            return yard;
        }
    },

for some reason when its V9(or H9) it breaks but when i put in V09 it works.

Can someone tell me why?

EDIT: it breaks as in... I have two variables start and end

so i have something like start = get100YardVersionEugene("V9")
and I use start and end to draw it on html5 canvas

start = get100YardVersionEugene("V9") //doesn't draw correctly start = get100YardVersionEugene("V09") // draw correctly

What do you mean by "it breaks"? An error? A wrong result? Which one? — Martin Ender
– Martin Ender, Commented Oct 1, 2012 at 15:05
And have you looked at your JavaScript console for any reported errors? — David Thomas
– David Thomas, Commented Oct 1, 2012 at 15:05
If you are concerned about performance then don't use regexp for something simple like this, rather use the String routines. — Ron Wertlen
– Ron Wertlen, Commented Apr 24, 2013 at 13:35

gpojd · Accepted Answer · 2012-10-01 15:06:15Z

5

Try wrapping yard in [parseInt][1].

var yard = parseInt(spot.match(/([0-9]+)/), 10);

answered Oct 1, 2012 at 15:06

gpojd

23.2k8 gold badges45 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Denys Séguret Over a year ago

This doesn't work for "H09". See my answer for the reason : match returns an array.

I Hate Lazy · Accepted Answer · 2012-10-01 15:11:51Z

4

You can simplify your regex a little so it only checks for H or V.

regarding the number, you need to remember that match returns an Array, so you'll need to get the value by index. Also, you shouldn't need the capture group.

And actually, you should really just use one regex.

get100YardVersionEugene: function(spot)
{
     var parts = spot.match(/(H|V)([0-9]+)/);
     if (parts) {
        if (parts[1] == "H")
        {
            return 100-(+parts[2] || 0);
        }
        else //V
        {
            return +parts[2];
        }
    }
},

edited Oct 1, 2012 at 15:11

answered Oct 1, 2012 at 15:06

I Hate Lazy

49k13 gold badges89 silver badges79 bronze badges

Comments

PiTheNumber · Accepted Answer · 2012-10-01 15:10:33Z

2

regexp is total overkill for this. Try String.charAt() or String.substr():

get100YardVersionEugene: function(spot)
{
   var team = spot.charAt(0);
   var yard = parseInt(spot.substr(1,2), 10);

   ...
}

Demo: http://jsfiddle.net/yzq9j/2/

answered Oct 1, 2012 at 15:10

PiTheNumber

23.7k17 gold badges114 silver badges191 bronze badges

Comments

Denys Séguret · Accepted Answer · 2012-10-01 15:13:31Z

2

The result of the match function is an array. Do this :

 var team = spot.match(/[A-Z]+/)[0];

And you also need to parse the result as int.

Alternatively, it doesn't seem like regex are really needed here :

var team = spot.substring(0, 1);
var yard = parseInt(spot.substring(1), 10);
return team=='H' ? (100-yard) : yard;

edited Oct 1, 2012 at 15:13

answered Oct 1, 2012 at 15:06

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

Comments

Seb T. · Accepted Answer · 2012-10-01 15:11:05Z

1

You probably need to convert your yard into number

if( team == H ){
 return 100-parseInt(yard);
}

Then might be good to check for convertion validity using isNaN method.

Hope this helps.

answered Oct 1, 2012 at 15:11

Seb T.

1,1341 gold badge12 silver badges27 bronze badges

Comments

Anoop · Accepted Answer · 2012-10-01 15:11:43Z

1

Modified code: spot.match(/([0-9]+)/) is returing an array

function get100YardVersionEugene(spot)
{
        var team = spot.match(/[A-Z]+/);
        var yard = spot.match(/([0-9]+)/);
       console.log(team , yard );
        if (team == "H")
        {
            return 100-yard[0];
        }
        else //V
        {
            return yard[0];
        }
    }

answered Oct 1, 2012 at 15:11

Anoop

23.2k10 gold badges65 silver badges79 bronze badges

Collectives™ on Stack Overflow

Javascript Regex Match()

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related