c++ pointer to array of strings

Question

Have a look at this code: I am trying to read in a number of strings from the console and store them in a dynamic array.

int Doctor::addPatients()
{
  string* names = NULL;
  int num;
  cout << "how many patients are to be added? ";
  cin >> num;
  numPatients=num;
  names = new string[numPatients];
  for(int i=0;i++;i<numPatients){
    cout << "enter the next patient's name: ";
    cin.clear();
    cin >> names[i];
  }
  patients = names; //patients is a private member variable of class Doctor
}

When I execute this code, I get the following error:

malloc: *** error for object 0x10c100898: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
Abort trap: 6

Any help is greatly appreciated

Stop using pointers, change to std::vector instead.

Some programmer dude
– Some programmer dude

2012-10-03 13:26:42 +00:00
Commented Oct 3, 2012 at 13:26 — Some programmer dude
– Some programmer dude, Commented Oct 3, 2012 at 13:26

Community · Accepted Answer · 2017-05-23 11:56:17Z

3

for(int i=0;i++;i<numPatients)  // Condition is the second expression in for syntax

Wrong syntax.

for(int i=0;i<numPatients; i++)

What compiler are you using ? You should get a compilation error than a run-time error. Also did you write a copy constructor ? For more info see Rule of Three. To ease the job, use std::vector<std::string>.

edited May 23, 2017 at 11:56

CommunityBot

11 silver badge

answered Oct 3, 2012 at 13:29

Mahesh

34.7k23 gold badges93 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jefferson Hudson Over a year ago

Man I really messed up that for loop. Thank you. One of those things I didn't even think about looking at again (after fixing the first problem). I'm using g++ on Mac OSX, Xcode 4.4.1, no flags except for -g when debugging.

ISTB · Accepted Answer · 2012-10-03 13:25:59Z

3

you do not initialize the integer i

answered Oct 3, 2012 at 13:25

ISTB

1,8253 gold badges24 silver badges31 bronze badges

2 Comments

ISTB Over a year ago

For example: std::shared_ptr<std::string> s(new std::string());

Jefferson Hudson Over a year ago

Using shared pointers sounds like a good idea. That said, I'd still like to know the problem with the code as written.

Mahesh · Accepted Answer · 2012-10-03 14:47:14Z

1

In the for statement, for(int i;i++;i<numPatients)

i should be initialised to 0 and condition should be the second parameter Correct format should be -

for(int i=0;i<numPatients;i++)

cin is not good method to get the string input. cin reads only till it sees space character (space,newline,tab..) Alternatively use getline function -

syntax:

getline(cin,names[i])

edited Oct 3, 2012 at 14:47

Mahesh

34.7k23 gold badges93 silver badges116 bronze badges

answered Oct 3, 2012 at 13:28

karpanai

2355 silver badges16 bronze badges

1 Comment

Mahesh Over a year ago

Formatting wasn't good enough and stripped out the explanation.

Collectives™ on Stack Overflow

c++ pointer to array of strings

3 Answers 3

1 Comment

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related