Java - ImageIcon not working in FOR Loop

Question

I have 30 ImageIcons that I have declared in a ImageIcon array. I have declared them all using a FOR loop. THe only problem is that when I try to add the ImageIcon to a JLabel and display the JPanel on the screen, it doesn't work.Here is my code:

package screens;

import javax.swing.*;

import java.awt.*;

public class gameScreen extends JPanel {
        private static final long serialVersionUID = 1L;
        // -------------VARIABLES---------------//
        Image wallpaper  = (Image)Toolkit.getDefaultToolkit().getImage(getClass().getResource("images/wallpaper.jpg"));


        ImageIcon[] teamsImg = new ImageIcon[30];
        public gameScreen() {

        for(int i = 0;i>30;i++){
            teamsImg[i] = new ImageIcon(Toolkit.getDefaultToolkit().getImage(
        getClass().getResource("images/img.png")));


         }

         JLabel label = new JLabel(teamsImg[27]);
         add(label);

    }

// -------------PAINT FUNCTION----------//
public void paintComponent(Graphics g) {
     g.drawImage(wallpaper,0,0,null);



}

}

Please, please, please, always call super.paintXxx, the paint methods do a lot of important work that you should not neglect unless you a have a very, Very, VERY good reason to. ps I doubt that's your problem, but that just annoys me :P — MadProgrammer
– MadProgrammer, Commented Oct 4, 2012 at 0:36
What exactly do you mean by 'it doesn't work' - do you get an error, or is it just that nothing is visible? Do the images exist? Are they actually loaded? Why are you you loading the same image 30 times, and then using it only once? Is the 'gameScreen' instance a non-zero size? Oh, and class names should start with capital letters. — GreyBeardedGeek
– GreyBeardedGeek, Commented Oct 4, 2012 at 0:41
nothing is visible. and the images aren't loaded. i checked using a if stament — basketballhead24
– basketballhead24, Commented Oct 4, 2012 at 0:49

MadProgrammer · Accepted Answer · 2012-10-04 00:54:26Z

3

I would take a really long, hard look at this line...

for (int i = 0; i > 30; i++) {

As Adam Savage would say, "well, there's your problem".

Personally, I would use ImageIO over Toolkit.getImage, unless you have a really good reason not to (like you need the background loading capabilities of Toolkit.getImage due to slow network connection). ImageIO will give you access to a much wider range of possible image formats, thanks to it's plugin architecture as well as guarantee that when it returns, the image will fully loaded.

Something like...

try {
    wallpaper = ImageIO.read(getClass().getResource("images/wallpaper.jpg"));

    for (int i = 0; i < 30; i++) {

        teamsImg[i] = ImageIO.read(getClass().getResource("images/img.png"));

    }
} catch (IOException iOException) {
    System.err.println("Bad things happened");
    iOException.printStackTrace();
}

This will require to use Image instead of ImageIcon to store the images, but it's a little sacrifice for the benefit it brings you.

Also, you do know, you're loading the same image over and over again??? You could just load it once and set the reference to each element in the array, it's effectively the same thing...(as I understand it, the image API is using a cached version to make repeated loads quicker)

enter image description here

edited Oct 4, 2012 at 0:54

answered Oct 4, 2012 at 0:44

MadProgrammer

348k22 gold badges243 silver badges379 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MadProgrammer Over a year ago

Look at the line in your code, then look at the sample code I provided using ImageIO

Collectives™ on Stack Overflow

Java - ImageIcon not working in FOR Loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related