Data validation with entity framework

Question

I am using ADO.Net entity framework with asp.net mvc3. I have a model which is database first. The data validation does not work in some cases, as I will explain.

I have a form, when I submit that form, some items are being validated while others are not. I am simply using a form like this,

    @using (Html.BeginForm()) {
    @Html.ValidationSummary(true)


   <fieldset>
        <legend></legend>


         <div class="editor-label">
            @Html.LabelFor(model => model.VERSION_ID)
            @Html.EditorFor(model => model.VERSION_ID)
            @Html.ValidationMessageFor(model => model.VERSION_ID)
        </div>

        <div class="editor-field">
            @Html.LabelFor(model => model.ENTITY2.Name)
            @Html.EditorFor(model => model.ENTITY2.Name)
            @Html.ValidationMessageFor(model => model.ENTITY2.Name)
        </div>
    <p>
        <input type="submit" value="Create" />
    </p>

Now, the version_id has validation working while the Name does not. I am getting the name from another entity. Any ideas on why the validation is not working? I can input empty fields which should not be allowed as that field is required, but when i press submit i get an error.

I just set the field to required. When i run the program, and submit, i get an error telling me that i cannot set that value to empty. The database first model set all the validation for me. — deep
– deep, Commented Oct 5, 2012 at 20:32

Shyju · Accepted Answer · 2012-10-05 20:27:12Z

3

I think your Model class is allowing empty values.

I would avoid using the Model classes directly in Views and create a separate ViewModel (a POCO class) for that. The ViewModel should have only relevant properties which the view requires. Not all the Properties of domain model most of the time !. you can use data annotations on the ViewModel( Required attribute etc...)

public class VersionViewModel
{
  [Required]
  public string VersionID { set;get;}

  [Required]
  public string Name { set;get;}
}

Your View will be strongly typed to this ViewModel. When posted back to the action method, you will map the values from the ViewModel fo your domain model and save it.

[HttpPost]
public ActionResult Edit(VersionViewModel model)
{
  if(ModelState.IsValid)
  {
     //validation is ok. Let's save
    var domainModel=new Version();
    domainModel.VERSION_ID=model.VersionID ;
    domainModel.Name=model.Name;

    //Let's save and REdirect 
    yourRepositary.SaveVersion(domainModel);
    return RedirectToAction("Saved",new { id=model.ID});     
  }
  return View(model);
}

Instead of manually mapping, you may consider using the libraries like AutoMapper.

answered Oct 5, 2012 at 20:27

Shyju

220k106 gold badges421 silver badges499 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Shyju Over a year ago

your ViewModels are different than your entities.VM's are specific to transfer data from view to action methods and back.

deep Over a year ago

this worked, why is it that whenever i set public int BLAH, without the [REQUIRED] and run the code, it still tells me that it is required field. When i set it to a string its doesn't tell me its required

Collectives™ on Stack Overflow

Data validation with entity framework

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related