C# 3.0 - Object initializer

Question

I'm having a little problem and I don't see why, it's easy to go around it, but still I want to understand.

I have the following class :

public class AccountStatement : IAccountStatement
{
     public IList<IAccountStatementCharge> StatementCharges { get; set; }

    public AccountStatement()
    {
        new AccountStatement(new Period(new NullDate().DateTime,newNullDate().DateTime), 0);
    }

    public AccountStatement(IPeriod period, int accountID)
    {
        StatementCharges = new List<IAccountStatementCharge>();
        StartDate = new Date(period.PeriodStartDate);
        EndDate = new Date(period.PeriodEndDate);
        AccountID = accountID;
    }

     public void AddStatementCharge(IAccountStatementCharge charge)
    {
        StatementCharges.Add(charge);
    }

}

(note startdate,enddate,accountID are automatic property to...)

If I use it this way :

var accountStatement = new AccountStatement{
                                              StartDate = new Date(2007, 1, 1),
                                              EndDate = new Date(2007, 1, 31),
                                              StartingBalance = 125.05m
                                           };

When I try to use the method "AddStatementCharge: I end up with a "null" StatementCharges list... In step-by-step I clearly see that my list get a value, but as soon as I quit de instantiation line, my list become "null"

Brad Wilson · Accepted Answer · 2008-09-24 15:21:23Z

18

This code:

public AccountStatement()
{
    new AccountStatement(new Period(new NullDate().DateTime,newNullDate().DateTime), 0);
}

is undoubtedly not what you wanted. That makes a second instance of AccountStatement and does nothing with it.

I think what you meant was this instead:

public AccountStatement() : this(new Period(new NullDate().DateTime, new NullDate().DateTime), 0)
{
}

answered Sep 24, 2008 at 15:21

Brad Wilson

71.3k9 gold badges78 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

TcKs · Accepted Answer · 2008-09-24 15:23:56Z

4

Use

public AccountStatement() : this(new Period(new NullDate().DateTime,newNullDate().DateTime), 0) { }

insetad of

public AccountStatement()
    {
        new AccountStatement(new Period(new NullDate().DateTime,newNullDate().DateTime), 0);
    }

answered Sep 24, 2008 at 15:23

TcKs

26.8k11 gold badges72 silver badges110 bronze badges

Comments

Chris Wenham · Accepted Answer · 2008-09-24 15:22:38Z

3

Your parameter-less constructor creates a new instance of itself, but doesn't assign it to anything.

answered Sep 24, 2008 at 15:22

Chris Wenham

24.1k13 gold badges62 silver badges73 bronze badges

Comments

Borek Bernard · Accepted Answer · 2008-09-24 15:30:26Z

-2

You are calling a parameter-less constructor so AddStatementCharge is never initialized. Use something like:

var accountStatement = new AccountStatement(period, accountId) {
                                          StartDate = new Date(2007, 1, 1),
                                          EndDate = new Date(2007, 1, 31),
                                          StartingBalance = 125.05m
                                       };

answered Sep 24, 2008 at 15:30

Borek Bernard

53.7k63 gold badges180 silver badges248 bronze badges

1 Comment

pmlarocque Over a year ago

cannot my parameter less constructor was calling the other one, and I don't have the accountID so can't call it directly. Must use the :this like stated previously. or simply put a return in front of my new in the parameter-less ctor. Thanks!

Collectives™ on Stack Overflow

C# 3.0 - Object initializer

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related