Why is my jquery json each() loop returning undefined?

Question

Here is my local Json which is validating in Jsonlint.

{
"messages": {
    "count": "0",
    "items": [
        {
            "MessageID": "1",
            "Starred": 0,
            "BodyPrev": "You wouldn't believe what has just happenedYou wouldn't believe what has ",
            "FromUserID": "1",
            "FromName": "Daisy Purdye",
            "FromUN": "daisypurdye",
            "Subject": "Yeayeah",
            "Body": "You wouldn't believe what has just happenedYou wouldn't believe what has just happenedYou wouldn't believe what has just happenedYou wouldn't believe what has just happenedYou wouldn't believe what has just happenedYou wouldn't believe what has just happened",
            "Ctime": "10/4/2012",
            "isRead": "1"
        },
        {
            "MessageID": "2",
            "Starred": 1,
            "BodyPrev": "Whatever",
            "FromUserID": "1",
            "FromName": "Daisy Purdye",
            "FromUN": "daisypurdye",
            "Subject": "Not true mate",
            "Body": "Whatever",
            "Ctime": "5/3/2012",
            "isRead": "1"
        }
    ]
}

}

and here is the jQuery to print out the messages...

    <script>
    $.getJSON("/json/messages.json",function(result){
        $.each(result, function(i, messages){
            console.log(messages.items.Subject)
        });
      });
   </script>

It is just returning undefined.

Denys Séguret · Accepted Answer · 2012-10-08 12:39:00Z

5

$.each should receive an array and you pass it the root object, which isn't an array, as your array of messages is in result.messages.items.

To iterate over the messages, you should do

  $.getJSON("/json/messages.json",function(result){
    $.each(result.messages.items, function(i, message){
        console.log(message.Subject)
    });
  });

answered Oct 8, 2012 at 12:39

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Chris Dowdeswell Over a year ago

Excellent, thanks. This was one of those problems my tired mind could have looked at it all day long and still not seen the obvious :D this makes perfect sense. Ill accept the answer in a few mins when I'm allowed.

jenson-button-event · Accepted Answer · 2012-10-08 12:39:21Z

0

Items is itself an array so im guessing you need to at least access it like:

messages.items[0].Subject

answered Oct 8, 2012 at 12:39

jenson-button-event

19k13 gold badges99 silver badges165 bronze badges

Comments

Anoop · Accepted Answer · 2012-10-08 12:39:47Z

0

items is an array. you should iterate through it to get all items.

 <script>
    $.getJSON("/json/messages.json",function(result){
        $.each(result, function(i, messages){
          $.each(messages.items, function(index, item){
                 console.log(item.Subject)
           });

        });
      });
   </script>

answered Oct 8, 2012 at 12:39

Anoop

23.2k10 gold badges65 silver badges79 bronze badges

Comments

Guffa · Accepted Answer · 2012-10-08 12:41:17Z

0

The items property is an array, so you can't use items.Subject.

Loop through the items in the array, instead of looping through the properties in the root object:

$.getJSON("/json/messages.json",function(result){
  $.each(result.messages.items, function(i, item){
    console.log(item.Subject)
  });
});

answered Oct 8, 2012 at 12:41

Guffa

703k111 gold badges760 silver badges1k bronze badges

Comments

Carlos Martinez T · Accepted Answer · 2012-10-08 12:42:09Z

0

There seems to be a problem with the logic. Try this:

<script>
        $.getJSON("/json/messages.json",function(result){
            $.each(result.items, function(i, item){
                console.log(item.Subject)
            });
          });
       </script>

answered Oct 8, 2012 at 12:42

Carlos Martinez T

6,5481 gold badge36 silver badges40 bronze badges

Comments

subodh · Accepted Answer · 2012-10-08 12:46:31Z

0

your object exist in this form

MainObj---> messages -----> items---->Subject

so if you need to print the subject then you have to access in the same manner as they exist

result.messages.items.Subject

answered Oct 8, 2012 at 12:46

subodh

6,15813 gold badges53 silver badges73 bronze badges

Collectives™ on Stack Overflow

Why is my jquery json each() loop returning undefined?

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related