Adding values into array in while loop overriding old values

Question

This is my code:

if ( 0 < $matches->total() ) {
    while ( $matches->fetch() ) {
        ?>
            <?php $ma1_winner      = $matches->display( 'winner' ); ?>
            <?php $ma1_team_1      = $matches->display( 'team_1' ); ?> 
            <?php $matches_array_1['winner'] = $ma1_winner; ?>
                <?php $matches_array_1['team1'] = $ma1_team_1; ?>
            <?php
                    } // end of while loop
            } // end of if any exists
            ?>


            <?php var_dump($matches_array_1); ?>
            <?php die(); ?>

But it outputs in var_dump only one winner and team not 15 from my database. How to fix it?

You only need/should only have one open/close pair of <?php ?> for that entire block of code. — Michael Berkowski
– Michael Berkowski, Commented Oct 11, 2012 at 18:06

Michael Berkowski · Accepted Answer · 2012-10-11 18:07:31Z

1

For each iteration, append a new array with winner and team as its keys. The result will be a 2-dimensional array containing all your values.

while ($matches->fetch() {
  // Append a new array via [] = array()
  // for every loop iteration
  $matches_array_1[] = array(
     'winner'=>$matches->display('winner'), 
     'team'=>$matches->display('team')
  );
}
var_dump($matches_array_1);

Otherwise, you are just overwriting the same two keys winner and team on every iteration.

answered Oct 11, 2012 at 18:07

Michael Berkowski

271k47 gold badges450 silver badges395 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Derfder Over a year ago

working! great, thanks a lot. Could I ask you why my code was not working?

Michael Berkowski Over a year ago

@Derfder Yours didn't work because on every loop iteration, you were just setting the keys winner,team of a 1-dimensional array to the current loop's fetched values. Over and over, you overwrote the same two array keys.

Derfder Over a year ago

ok, thanks a lot, I will tick your answer in 6 minutes according to the popup

raidenace · Accepted Answer · 2012-10-11 18:11:04Z

1

You need some kind of unique match identifier for each match when constructing the array. Something like:

<?
if ( 0 < $matches->total() ) 
{
    while ( $matches->fetch() ) 
    {
        $matches_array_1[$matches->display('match_id')]['winner'] = $matches->display( 'winner' );
        $matches_array_1[$matches->display('match_id')]['team1']  = $matches->display( 'team_1' );
    } // end of while loop
} // end of if any exists
var_dump($matches_array_1); 
die();
?>

answered Oct 11, 2012 at 18:11

raidenace

12.8k1 gold badge34 silver badges35 bronze badges

Collectives™ on Stack Overflow

Adding values into array in while loop overriding old values

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related