Loopj Android Async Http - onFailure not fired

Question

I am using the great async http library from loopj, but I have run into a small snag.

If the user has no internet connection or loses their connection, the app just won't return anything. This part is expected, but it also doesn't fire the onFailure method.

Also, the code I have used when there is an internet connection does work so there is no problem on the server end.

Here is some code that is stripped down to the minimum. It also doesn't work (I have tested this too)

String url = getString(R.string.baseurl) + "/appconnect.php";
client.getHttpClient().getParams().setParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS, true);
client.get(url, null, new JsonHttpResponseHandler()
{
    @Override
    public void onSuccess(JSONArray response)
    {
        Toast.makeText(getApplicationContext(), "Success", Toast.LENGTH_SHORT).show();
    }

    @Override
    public void onFailure(Throwable e, JSONArray errorResponse)
    {
        Toast.makeText(getApplicationContext(), "Failure", Toast.LENGTH_SHORT).show();
    }
});

Thanks, Ashley

Baz · Accepted Answer · 2012-11-12 21:18:08Z

7

You can try this:

In AsyncHttpRequest->makeRequestWithRetries(), add a catch to SocketException like this:

while (retry) {
        try {
            makeRequest();
            return;
        } catch (UnknownHostException e) {
            if(responseHandler != null) {
                responseHandler.sendFailureMessage(e, "can't resolve host");
            }
            return;
        } catch (SocketException e){
            // Added to detect no connection.
            if(responseHandler != null) {
                responseHandler.sendFailureMessage(e, "can't resolve host");
            }
            return;
        } catch (IOException e) {
            cause = e;
            retry = retryHandler.retryRequest(cause, ++executionCount, context);
        } catch (NullPointerException e) {
            // there's a bug in HttpClient 4.0.x that on some occasions causes
            // DefaultRequestExecutor to throw an NPE, see
            // http://code.google.com/p/android/issues/detail?id=5255
            cause = new IOException("NPE in HttpClient" + e.getMessage());
            retry = retryHandler.retryRequest(cause, ++executionCount, context);
        }
    }

edited Nov 12, 2012 at 21:18

Baz

37k11 gold badges75 silver badges101 bronze badges

answered Nov 12, 2012 at 21:02

nicous

4112 silver badges5 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

dbro Over a year ago

This is the solution! It's been merged by loopj! Nice one nicous!

Mathew M Visacanthara Over a year ago

Hi nicous, how can we edit AsyncHttpRequest.class Please help . Is there any way to edit this .class file inside the jar file

twaddington · Accepted Answer · 2012-10-12 21:44:33Z

7

Yeah, unfortunately the loopj Android library isn't very well designed. If you implement the other onFailure callbacks one of them should fire:

@Override
public void onFailure(Throwable e) {
    Log.e(TAG, "OnFailure!", e);
}
@Override
public void onFailure(Throwable e, String response) {
    Log.e(TAG, "OnFailure!", e);
}
@Override
public void onFailure(Throwable e, JSONArray errorResponse) {
    Log.e(TAG, "OnFailure!", e);
}

edited Oct 12, 2012 at 21:44

answered Oct 12, 2012 at 21:33

twaddington

11.6k5 gold badges37 silver badges49 bronze badges

1 Comment

Ashley Staggs Over a year ago

I tried these plus the JSONObject failure. Unfortunately it still isn't working.

tier777 · Accepted Answer · 2014-09-25 02:00:00Z

0

Try this:

@Override
protected Object parseResponse(byte[] responseBody) throws JSONException {
    return super.parseResponse(responseBody);
}

answered Sep 25, 2014 at 2:00

tier777

1,04512 silver badges11 bronze badges

Collectives™ on Stack Overflow

Loopj Android Async Http - onFailure not fired

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related