C++ pass array argument to a function

Question

I want to pass a reference to an array from one object GameModel to another PersonModel, store reference and then work with this array inside PersonModel just like inside GameModel, but...

I have a terrible misunderstanding of passing an array process: In the class PersonModel I want to pass an array by reference in a constructor (see code block below). But the marked line throws the compile error

    PersonModel::PersonModel( int path[FieldSize::HEIGHT][FieldSize::WIDTH], int permissionLevel ) { 
        this->path = path; //<------ ERROR here:
        //PersonModel.cpp:14:22: error: incompatible types in assignment of 'int (*)[30]' to 'int [31][30]'

        this->permissionLevel = permissionLevel;
    }

Here is the header file PersonModel.h

#ifndef PERSON_MODEL
#define PERSON_MODEL

#include "data/FieldSize.h"

namespace game{
    class IntPosition;
    class MotionDirection;

    class PersonModel {
        protected:
        int path[FieldSize::HEIGHT][FieldSize::WIDTH];
        int permissionLevel;

        public:
        PersonModel( int path[FieldSize::HEIGHT][FieldSize::WIDTH], int permissionLevel );
        void setMotionDirection ( MotionDirection* md);
        void step(long time);
        void reset(long time);
    };
}

#endif

As I see now, I can change the int path[FieldSize::HEIGHT][FieldSize::WIDTH]; declaration to int (*path)[FieldSize::WIDTH]; but it is much more confusing.

Help me understand this topic: what is the proper way to store the passed reference to an array to work with it later, like with usual 2D array.

UPDATE:

This array is a map of game field tiles properties represented by bit-masks, so it is read-only actually. All the incapsulated objects of GameModel class should read this array, but I definitely don't want to duplicate it or add some extra functionality.

There are no frameworks just bare Android-NDK.

Looks like you have to declare the path (the member of the class) to be a reference (well, pointer), instead of an array. — fork0
– fork0, Commented Oct 14, 2012 at 18:50
Array in C++ is rather a low-level, legacy C construct, and while it has its place in C++, you should at least consider using C++ data structures, such as those in STL, like std::vector, or those provided by some framework you are using (like QList of Qt). — hyde
– hyde, Commented Oct 14, 2012 at 18:54
anton-boritskiy: no. Like int (*path)[WIDTH]; and save the height somewhere. — fork0
– fork0, Commented Oct 14, 2012 at 19:30

Roddy · Accepted Answer · 2012-10-14 19:12:40Z

3

I think you've fallen into the classic trap of believing someone who's told you that "arrays and pointers are the same in C".

The first thing I'd do would be to define a type for the array:

typedef int PathArray[FieldSize::HEIGHT][FieldSize::WIDTH];

You then don't need to worry about confusions between reference to array of ints vs array of references to ints.

Your PersonModel then contains a reference to one of these.

PathArray &path;

and, because its a reference it must be initialised in the constructors initialization list rather than in the constructor body.

 PersonModel::PersonModel( PathArray &aPath, int aPermissionLevel ) :
   path(aPath),
   permissionLevel(aPermissionLevel)
 {
 }

Of course, holding references like this is a little scary so you might want to consider using a boost::shared_ptr or something similar instead to make the lifetime management more robust.

answered Oct 14, 2012 at 19:12

Roddy

68.5k45 gold badges173 silver badges282 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

chradcliffe Over a year ago

Making the member reference const would help to clarify that the array is read-only inside the class.

chradcliffe Over a year ago

If the GameModel contains all the PersonModel instances, then using a reference is likely reasonable and not scary at all. In that case, a shared_ptr would be unnecessary. Of course the object lifetime of the PersonModels instances would have to be strict.

Roddy Over a year ago

@chradcliffe - yes, both valid points . I'm always a bit wary when I see classes holding 'bare' references, but that's probably just me...

Anton Boritskiy Over a year ago

is it possible to return such array from a function using return construct like this PathArray getTabletPath(); or something similar to call later like 'PathArray path = getTabletPath()' ?

Roddy Over a year ago

@AntonBoritskiy - Yes, perfectly possible. You could also return a reference to one (but beware returning references to variables that go out of scope!!) PathArray & getPA() { PathArray p; return p; //death! };

cooky451 · Accepted Answer · 2012-10-14 18:46:55Z

2

You cannot assign arrays as you do with value types in C++
int path[x][y] resolves to the type int (*)[y]

Possible solutions are:

Using memcpy/copy
Using std::array

answered Oct 14, 2012 at 18:46

cooky451

3,5201 gold badge25 silver badges39 bronze badges

2 Comments

Seth Carnegie Over a year ago

I would recommend against recommending memcpy when you have std::copy but it's not enough for a downvote.

cooky451 Over a year ago

Well, and I would recommend std::array. :D

Some programmer dude · Accepted Answer · 2012-10-14 18:43:09Z

0

You can't assign to an array like that. However you can use the fact that an array is a contiguous memory area, even when having an array of arrays, and use e.g. memcpy to copy the array:

memcpy(this->path, path, FieldSize::HEIGHT * FieldSize::WIDTH * sizeof(int));

answered Oct 14, 2012 at 18:43

Some programmer dude

411k36 gold badges420 silver badges655 bronze badges

2 Comments

Anton Boritskiy Over a year ago

thanks, but my idea was to use only one instance of this array

Seth Carnegie Over a year ago

Why memcpy when you can std::copy?

bobestm · Accepted Answer · 2012-10-14 21:56:57Z

0

You would have to pass a pointer to the 2d-array as you cannot pass the array as you have stated in the code snippet. I would suggest using the STL array type. Admittedly std::array is C++ '11 standard and therefore old compiler may not support it. You can also use vector which has been around longer.

vector<vector<int>>path;

You will have to resize the 2d-vector in the constructor. Indexing would look a bit funny:

path[1].[1] ....

With vectors, you can then pass it by reference.

answered Oct 14, 2012 at 21:56

bobestm

1,3341 gold badge9 silver badges8 bronze badges

Comments

Moamen · Accepted Answer · 2013-12-28 23:31:33Z

0

the name of the array is a pointer on first element so, you can try

PersonModel( int (*path)[FieldSize::HEIGHT][FieldSize::WIDTH], int permissionLevel );

answered Dec 28, 2013 at 23:31

Moamen

112 bronze badges

Comments

BigBoss · Accepted Answer · 2012-10-14 18:45:46Z

-3

In C++ '=' implemented for primitive types like int and double but not for array(array is not a primitive type), so you should never use '=' to assign an array to new array, instead you should use something as memcpy to copy array. memcpy copy a memory over another memory, so you can use it to copy an array over another array:

// memcpy( dst, src, size );
memcpy( this->path, path, FieldSize::HEIGHT * FieldSize * WEIGHT * sizeof(int) );

answered Oct 14, 2012 at 18:45

BigBoss

6,9243 gold badges26 silver badges39 bronze badges

2 Comments

Anton Boritskiy Over a year ago

but it would make a copy and not a reference.. My idea was to use only one instance of this array.

Ed Swangren Over a year ago

It has nothing to do with primitive types, arrays are not assignable by design.

Collectives™ on Stack Overflow

C++ pass array argument to a function

6 Answers 6

5 Comments

2 Comments

2 Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

5 Comments

2 Comments

2 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related