While loop to check character input

Question

I am trying to accept input from the user in the form of a character. I have that working but I need to check and make sure it is one of 6 characters (H, h, S, s, L, l). I have a while loop but as soon as add more than one character statement to it, the loop gives the error for every value that should be correct.

Here is the function:

    private static char getHighLow(Scanner keyboard) 
{
    System.out.println("High, Low, or Sevens (H/L/S): ");
    String choiceString = keyboard.next();

    char choice = choiceString.charAt(0);

    while (choice != 'H' || choice != 'h' || choice != 'L' || choice != 'l' || choice != 'S' || choice != 's')
    {
        System.out.println("You have entered an invalid entry.");
        System.out.println("High, Low, or Sevens (H/L/S): ");
        choiceString = keyboard.next();
    }

    return choice;

}

What is the best way to continue checking for multiple characters like this?

John Kugelman · Accepted Answer · 2012-10-15 15:05:26Z

4

Use && instead of ||.

while (choice != 'H' && choice != 'h' && choice != 'L' && choice != 'l' && choice != 'S' && choice != 's')

This can be simplified by converting to lower case first.

choice = Character.toLowerCase(choice);

while (choice != 'h' && choice != 'l' && choice != 's')

answered Oct 15, 2012 at 15:05

John Kugelman

364k70 gold badges555 silver badges600 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1661235 Over a year ago

Perfect that did it. I think I'm getting the logic for this now, but correct me if I'm wrong. I don't want to enter that loop unless none of those characters are entered. So it checks each character and fails because every single AND needs to be true?

pb2q · Accepted Answer · 2012-10-15 15:30:46Z

3

There is an error in your logic: you should be connecting those tests with AND: &&:

while (choice != 'H' && choice != 'h' && choice != 'L' && ...

Furthermore choice is never being updated within the body of the loop, so it will never change. Duplicate the choice = choiceString.charAt(0); after you re-read choiceString within the loop.

Conceptually, you want to keep asking for input so long as the character isn't H AND isn't L AND isn't S.

edited Oct 15, 2012 at 15:30

answered Oct 15, 2012 at 15:05

pb2q

59.9k19 gold badges150 silver badges152 bronze badges

Comments

Baz · Accepted Answer · 2012-10-15 15:05:49Z

2

You never update choice in your while loop:

Just add this line at the end of your loop:

choice = choiceString.charAt(0);

Moreover you should check with && rather than ||.

answered Oct 15, 2012 at 15:05

Baz

37k11 gold badges75 silver badges101 bronze badges

Collectives™ on Stack Overflow

While loop to check character input

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related