PHP Foreach Loop with If

Question

Trying to loop thru a result that has items. Items have a type and trying to echo out the category title for each group. Normally this works excellent with one loop but the $item-type foreach I Think is throwing things off. Any solutions?

<h2>Package <?=$packages->id?></h2>

<?php foreach($packages->item as $item):?>

    <?php foreach($item->type as $type):?>

        <?php $subtype = null;?>

        <?php if($subtype != $type->name)?>

            <h3><?=$type->name?></h3>

            <?=$item->name?><br>

            <?php $subtype = $type->name;?>

    <?php endforeach;?>

<?php endforeach;?>

DB structure:

items
    id   name
    1    mainitem1
    2    mainitem2
    3    item1
    4    item2
    5    item3
    6    item4

types
    id   name
    1    category 1
    2    category 2
    3    subcategory1
    4    subcategory2

item_type
    id   item_id   type_id
    1    1         1
    2    2         2
    3    3         3
    4    4         3
    5    5         4
    6    6         4

packages
    id   item_id
    1    1
    2    2

item_package
    id   package_id   item_id
    1    1            3
    2    1            5
    3    2            4
    4    2            6

What my result currently is:

package 1
    category 1
        item 3
    category 1
        item 5
    category 2
        item 4
    category 2
        item 6

Desired result:

package 1
    category 1
        item 3
        item 5
    category 2
        item 4
        item 6

Add it to paste bin .. want to be sure of what am dealing with here — Baba
– Baba, Commented Oct 16, 2012 at 0:51

Baba · Accepted Answer · 2012-10-16 01:04:36Z

1

$subtype has no role to play since it was set to Null before the if statement

$subtype = null;
if($subtype != $type->name)  <------- This would always be true

Category Name is also duplicated since its in the inner loop instead of outer loop

This is all i think you need

printf("<h2>%s</h2>", $packages->id);
foreach ( $packages->item as $item ) {
    printf("<h3>%s</h3>", $type->name);
    print("<ul>");
    foreach ( $item->type as $type ) {
        printf("<li>%s</li>", $item->name);
    }
    print("</ul>");
}

edited Oct 16, 2012 at 1:04

answered Oct 16, 2012 at 0:52

Baba

95.3k29 gold badges172 silver badges222 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

dynamo Over a year ago

This is still giving me the same result, check my comment above with my pastebin.

Baba Over a year ago

@dynamo let me work with your real objects then add serialize($packages) to past bin .. i would be able to work with your objects directly

dynamo Over a year ago

Figured out my code does work correctly, just has to be a php block and not open/close each line. Going to accept because your code helped me figure it out.

Baba Over a year ago

@dynamo good to know .... but you don't have to write if else that way ... You need to make your code clean and readable

Rubin Porwal · Accepted Answer · 2012-10-16 02:55:56Z

1

As a solution to your above mentioned problem please refer the below code snippet

    <h2>Package <?=$packages->id?></h2> 
   <?php foreach($packages->item as $item):?> 
    <h3><?php echo $item->name;?></h3>

   <?php foreach($item->type as $type):?>
   <?php $subtype = null;?> 
   <?php if($subtype != $type->name)?> 
    <?=$type->name?><br> 
   <?php $subtype = $type->name;?> 
  <?php endforeach;?> 
  <?php endforeach;?>

answered Oct 16, 2012 at 2:55

Rubin Porwal

3,8451 gold badge27 silver badges27 bronze badges

Collectives™ on Stack Overflow

PHP Foreach Loop with If

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related