mvc c# return view() not defaulting to correct values

Question

I am not sure if I am overlooking something obvious. Once I do a POST, I have the following (Note: What I am trying to do is to default the same view with some null values so the user can create another entry):

    [HttpPost]
    public ActionResult QkInsert(ProgInfo model)
    {

        if (ModelState.IsValid)
        {
            ProgService.InsertQuickEntry(model);


            model.Name = null;
            model.Address = null;
            model.Phone = null;            

            return view(model);


        }

         return view(model);

What is strange is that when I look at the value of model in the IsValid()

    return view(model)

I do see the null values. But when it is shown on the view, it is not null. It is basically the same view as when I had entered the data the first time. Any idea? Have I overlooked something?

Also notice how I have done return view(model) twice. Is there any other way of doing this to where I do it only once and not repeat?

You don't need the return inside the if statement

James
– James

2012-10-18 18:02:10 +00:00
Commented Oct 18, 2012 at 18:02 — James
– James, Commented Oct 18, 2012 at 18:02

Darin Dimitrov · Accepted Answer · 2012-10-19 06:19:56Z

2

That's because HTML helpers are first looking into the ModelState when binding their values and only after that the value in your model. This is by design.

So if you want to change any value of the model inside a POST action you need to remove it from the ModelState first:

[HttpPost]
public ActionResult QkInsert(ProgInfo model)
{
    if (ModelState.IsValid)
    {
        ProgService.InsertQuickEntry(model);

        ModelState.Remove("Name");
        ModelState.Remove("Address");
        ModelState.Remove("Phone");
        model.Name = null;
        model.Address = null;
        model.Phone = null;            

        return view(model);
    }

    ....
}

Now the view will render the modified values.

answered Oct 19, 2012 at 6:19

Darin Dimitrov

1.0m276 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dove · Accepted Answer · 2012-10-18 18:02:55Z

1

If the model is not valid you will return the same model, your second return.

There is no need at all for the first return view(model) as there is no code between it and the second one, so it will call anyway. That is, delete the first return and the logic is identical.

answered Oct 18, 2012 at 18:02

dove

20.8k14 gold badges88 silver badges109 bronze badges

2 Comments

Abbas Over a year ago

Don't know who -1'd you but +1 for the tip! :)

Nate Pet Over a year ago

@dove - Thanks but the thing is that it was a valid model and still it returned the same model even though I said for it to make certain values null

Collectives™ on Stack Overflow

mvc c# return view() not defaulting to correct values

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related