c# function, validate url within mvc app

Question

I'm trying to build a function within my mvc app that will validate the user's url input. in my code below, i get the "not all code paths return a value." I need help figuring out why it doesn't like when i return result. thanks!

public static long InsertUrl(string inputUrl)
        {
            long result = 0;
            if (!string.IsNullOrEmpty(inputUrl))
            {

                using (ShortUrlEntities db = new ShortUrlEntities())
                {

                    if (inputUrl.IndexOf(@"://test/") == -1)
                    {
                        inputUrl = "http://test/" + inputUrl;
                    }

                    Regex RgxUrl = new Regex("(([a-zA-Z][0-9a-zA-Z+\\-\\.]*:)?/{0,2}[0-9a-zA-Z;/?:@&=+$\\.\\-_!~*'()%]+)?(#[0-9a-zA-Z;/?:@&=+$\\.\\-_!~*'()%]+)?");
                    if (RgxUrl.IsMatch(inputUrl))
                    {
                        ShortURL su = new ShortURL();
                        su.url = inputUrl;
                        db.AddToShortURLSet(su);
                        db.SaveChanges();
                        result = su.id;
                    }

                    return result;
                }
            }

        }
    }
}

Pierre-Alain Vigeant · Accepted Answer · 2009-08-19 12:54:15Z

1

You have an If

if (!string.IsNullOrEmpty(inputUrl))

and your return is inside that if. In the event that the inputUrl is null or empty, you are not returning anything.

Move your return Result; to outside the if.

answered Aug 19, 2009 at 12:54

Pierre-Alain Vigeant

23.2k8 gold badges67 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MG. Over a year ago

too easy, i guess i had been looking at the code too long. Thanks!

StarSignLeo · Accepted Answer · 2009-08-19 12:56:36Z

0

The problem is that if this:

if (!string.IsNullOrEmpty(inputUrl))

fails then no result will ever be returned. This is needed for all function that return a value not just in MVC.

answered Aug 19, 2009 at 12:56

StarSignLeo

2661 gold badge2 silver badges9 bronze badges

Collectives™ on Stack Overflow

c# function, validate url within mvc app

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related