PHP array not working, multiple

Question

Here's my code:

function prepare_machine($variables)
{
        foreach ($variables AS $varname => $vartype)
        {
                if (isset($_REQUEST[$varname]))
                {
                        $value = $_REQUEST[$varname];
                        return do_clean($value, $vartype);
                }
                else
                        exit;
        }
}

It is called like this:

prepare_machine(array('order_by_time' => TYPE_BOOLEAN));

it all works fine, but if you have multiple things in the array, for examples;

prepare_machine(array('order_by_time' => TYPE_BOOLEAN, 'order_by_date' => TYPE_BOOLEAN));

it will only do anything with the first one.

Can anybody see what is wrong with my code?

Thanks

staticsan · Accepted Answer · 2012-10-22 00:10:10Z

1

You're doing a return ... when you find a match in your inner loop. That's why it only processes one.

Also, you should be using array_key_exists($varname, $_REQUEST) because isset($_REQUEST[$varname]) will fail if $_REQUEST[$varname] is null.

answered Oct 22, 2012 at 0:10

staticsan

30.6k5 gold badges64 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

anon Over a year ago

Okay, so what should I do instead of the return?

staticsan Over a year ago

You need to ask why prepare_machine() returns what do_clean() returns. Whatever that answer is, you will need to re-engineer your code. Either prepare_machine() can't process more than one variable per call, or do_clean() needs to not return a "cleaned" value.

Niet the Dark Absol · Accepted Answer · 2012-10-22 00:10:36Z

0

return returns whatever you give it, and exits the function. You need to change your function somehow so that it only returns after processing all the variables.

answered Oct 22, 2012 at 0:10

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

1 Comment

anon Over a year ago

How would I do that, then? Thanks

Collectives™ on Stack Overflow

PHP array not working, multiple

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related