ASP.Net MVC3 Routing Issue

Question

I am working on a deal website and have defined the following route in the global.asax.

routes.MapRoute(
    "AboutFooter",
    "about-bicker-shop",
    new { controller = "Footer", action = "About" }
);

routes.MapRoute(
    "ContactFooter",
    "contact-bickershop",
    new { controller = "Footer", action = "Contact" }
);

routes.MapRoute(
    "PrivacyPolicyFooter",
    "privacy-policy",
    new { controller = "Footer", action = "PrivacyPolicy" }
);

routes.MapRoute(
    "TermsAndConditionsFooter",
    "terms-and-conditions",
    new { controller = "Footer", action = "TermsAndConditions" }
);

routes.MapRoute(
    "SiteMapFooter",
    "sitemap",
    new { controller = "Footer", action = "SiteMap" }
);

routes.MapRoute(
    "FAQFooter",
    "faq",
    new { controller = "Footer", action = "FAQ" }
);

routes.MapRoute(
    "UnsubscribeFooter",
    "unsubscribe",
    new { controller = "Footer", action = "Unsubscribe" }
);

routes.MapRoute(
    "GetDealsByCity",
    "daily-bickers/{cityName}",
    new { controller = "Home", action = "Home" }
);

routes.MapRoute(
    "GetDealsbyCategory",
    "daily-bickers/{cityname}/{category}",
    new { controller = "Home", action = "GetDealsByCategory" }
);

routes.MapRoute(
    "GetDealDetails",
    "{cityName}/{dealName}",
    new { controller = "Home", action = "GetDealsByDealName" }
);

routes.MapRoute(
    "DealCheckout",
    "{cityName}/{dealName}/checkout",
    new { controller = "Home", action = "CheckoutDealByDealName" }
);

routes.MapRoute(
    "Default", // Route name
    "{controller}/{action}/{id}", // URL with parameters
    new { controller = "Home", action = "Index", id = UrlParameter.Optional } // Parameter defaults
);

It works fine till the time I am viewing the details of the deal but I am getting an error when I click on the buy button to buy the deal.

On further research I found that on clicking the buy button, the code is invoking the GetDealsByDealName action and not the action CheckoutDealByDealName. Please suggest me the solution.

need to see the way the links are generated to understand why they may not be routing appropriately. — gudatcomputers
– gudatcomputers, Commented Oct 25, 2012 at 19:16
Can you post the mark up for the action links or buttons you are using? — AntLaC
– AntLaC, Commented Oct 25, 2012 at 19:17
<a href="@Url.Action("CheckoutDealByDealName", " Home", new { cityName = ViewBag.CityName, dealName = Model.GetDealDetailsByDealId.First().DealName.ToSeoUrl() })"> <img src="../../Content/Images/buy_now2.png" alt="" /> </a> — Naveen Goel
– Naveen Goel, Commented Oct 25, 2012 at 19:29
The following link is generated - http://{url}/{controller}/{action}?cityname="{cityname}anddealname="{dealname}/checkout while my expectation is http://{url}/{cityname}/{dealname}/checkout — Naveen Goel
– Naveen Goel, Commented Oct 26, 2012 at 8:54

Joel Etherton · Accepted Answer · 2012-10-25 19:46:25Z

2

MVC will always provide the very first route that it can find in the routing table that matches the route requested. In this case, the reason you're getting the wrong route is because they both match to the GetDealDetails route. Even though the second route is more specific, it won't ever be reached because the GetDealDetails will always match first. Try re-ordering your routes like this:

routes.MapRoute(
    "DealCheckout",
    "{cityName}/{dealName}/checkout",
    new { controller = "Home", action = "CheckoutDealByDealName" }
);

routes.MapRoute(
    "GetDealDetails",
    "{cityName}/{dealName}",
    new { controller = "Home", action = "GetDealsByDealName" }
);

This should allow the details route to not match the checkout route, but the checkout will be caught first during a collision. I'd really suggest you rename your routes entirely, but looking at what you have I can understand why you want these routes.

answered Oct 25, 2012 at 19:46

Joel Etherton

37.5k10 gold badges92 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Naveen Goel Over a year ago

As suggested, I tried re-ordering the routes but no success. Still getting the same error.

Naveen Goel Over a year ago

I tried renaming the route as routes.MapRoute( "DealCheckout", "{cityName}/{dealName}/checkout", new { controller = "Home", action = "CheckoutDealByDealName" } ); but this did not worked out too. It seems I have no other option but to completely change the route.

Joel Etherton Over a year ago

You might have more success by changing the route to checkout/{cityName}/{dealName}. That would change the route enough to be unique, but it'd still look pretty close to your original intent.

Naveen Goel Over a year ago

Even tried the same route but its not working, may be reason being both the actions has same signature and may be mvc routing considers the action signature and not the complete url to be formed.

Collectives™ on Stack Overflow

ASP.Net MVC3 Routing Issue

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related