Javascript Parameter Passing Not Working

Question

The code dynamically creates a listview which works but i want to make it so when a listview item is clicked it sends the a url paramater to another method. When i set a paramater it doesnt alert the paramater, but when i give no parameter it works.

var output = 
"<li onclick='openURL()'><h3> Module Code: " + 
results.rows.item(i).module 
+ "</h3>Room: " 
+ results.rows.item(i).room +
"</li>";

The above works - No parameter in openURL();

var output = 
    "<li onclick='openURL('" + results.rows.item(i).url + "')'><h3> Module Code: " + 
    results.rows.item(i).module 
    + "</h3>Room: " 
    + results.rows.item(i).room +
    "</li>";

The above doesnt work - I have done alert(results.rows.item(i).url) and it has a value.

function openURL(url) {
    alert("opening url " + url);
}

Could someone explain what i'm doing wrong, i've been trying to solve the problem for hours.

Cheers!

nested apostrophes: "<li onclick='openURL('" ..

Michal Klouda
– Michal Klouda

2012-10-26 14:17:59 +00:00
Commented Oct 26, 2012 at 14:17 — Michal Klouda
– Michal Klouda, Commented Oct 26, 2012 at 14:17
in second case ur getting null value for url argument?

Shekhar
– Shekhar

2012-10-26 14:17:59 +00:00
Commented Oct 26, 2012 at 14:17 — Shekhar
– Shekhar, Commented Oct 26, 2012 at 14:17

Polyana Fontes · Accepted Answer · 2012-10-26 14:18:22Z

4

You are using single quotes to open the HTML attribute, you can't use it as JavaScript String because you'll be closing the HTML attribute, use double quotes:

var output = 
    "<li onclick='openURL(\"" + results.rows.item(i).url + "\")'><h3> Module Code: " + 
    results.rows.item(i).module 
    + "</h3>Room: " 
    + results.rows.item(i).room +
    "</li>";

answered Oct 26, 2012 at 14:18

Polyana Fontes

3,2221 gold badge30 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript Parameter Passing Not Working

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related