Can't use variable in alert within function

Question

I am using this code as a part of a game I'm making. But for the purposes of finding out what was causing this bug I took the section of code into a new html document. I am trying to use this code:

<html>
<script type="text/javascript">
Difficulty = Normal
function ChangeGameMode()
{
  alert (Difficulty + ' game started ');
  }
</script>
<button type="button" class="StartButton" onclick="ChangeGameMode()">Start</button>
</html>

When I click the button, I don't get an alert. Nothing happens.

But if I don't use the Difficulty variable in the alert - ie:

alert ('Normal' + ' game started ');

Then when I use that for the alert instead, it does work. I am at conplete loss as to what is causing this and I have been pulling my hair out because of it. Any help would be appreciated.

Btw, you should lowercase all function and variable names unless they're constructors — Bergi
– Bergi, Commented Oct 27, 2012 at 15:09
Always check the Javascript console for error messages when something "does not work" — HBP
– HBP, Commented Oct 27, 2012 at 15:11

Darin Dimitrov · Accepted Answer · 2012-10-27 15:06:24Z

4

You haven't properly defined the Difficulty variable. You need to assign it a valid value. Normal is not a valid javascript value. You need to wrap it in quotes:

<html>
<script type="text/javascript">
var Difficulty = 'Normal';
function ChangeGameMode() {
    alert (Difficulty + ' game started ');
}
</script>
<button type="button" class="StartButton" onclick="ChangeGameMode()">Start</button>
</html>

answered Oct 27, 2012 at 15:06

Darin Dimitrov

1.0m276 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gabriel101x Over a year ago

Derp. I forgot to use normal as a string. I'm so used to using numbers for my variables instead of words.

David G · Accepted Answer · 2012-10-27 15:08:16Z

0

Normal must be in quotes:

var Difficulty = "Normal";

answered Oct 27, 2012 at 15:08

David G

97.6k41 gold badges173 silver badges258 bronze badges

Collectives™ on Stack Overflow

Can't use variable in alert within function

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related