jQuery replace text not working

Question

I am using this method to find and replace a piece of text and not sure why it is not working? When I use console.log, I can see the correct content I want to replace but the end result is not working:

(function($) {
  $(document).ready( function() {
        var theContent = $(".transaction-results p").last();
        console.log(theContent.html());
        theContent.html().replace(/Total:/, 'Total without shipping:');
    });
})(jQuery);

Any thoughts?

Thank you!

string.replace returns a string - it doesn't do the replace on the string you reference... theContent.html(theContent.html().replace(/Total:/, 'Total without shipping:')); — Reinstate Monica Cellio
– Reinstate Monica Cellio, Commented Nov 1, 2012 at 12:14

Community · Accepted Answer · 2017-05-23 11:48:11Z

3

The string was replaced, but you didn't reassign the string to the html of the element. Use return:

theContent.html(function(i,h){
    return h.replace(/Total:/, 'Total without shipping:');
});

JS Fiddle demo (kindly contributed by diEcho).

References:

html().

edited May 23, 2017 at 11:48

CommunityBot

11 silver badge

answered Nov 1, 2012 at 12:15

David Thomas

254k53 gold badges382 silver badges421 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adil · Accepted Answer · 2012-11-01 12:22:55Z

0

You have extra : in string to search and also assign it back to html of theContent

Live Demo

  $(document).ready( function() {
        var theContent = $(".transaction-results p").last();
        console.log(theContent.html());
        theContent.html(theContent.html().replace(/Total/, 'Total without shipping:'));
  });

edited Nov 1, 2012 at 12:22

answered Nov 1, 2012 at 12:16

Adil

148k25 gold badges217 silver badges207 bronze badges

Comments

ioan · Accepted Answer · 2012-11-01 12:15:31Z

0

(function($) {
  $(document).ready( function() {
        var theContent = $(".transaction-results p").last();
        console.log(theContent.html());
        theContent.html(theContent.html().replace('Total:', 'Total without shipping:'));
    });
})(jQuery);

Why you did /Total:/ and not 'Total' like a normal string?

-The solution from @David Thomas works.

answered Nov 1, 2012 at 12:15

ioan

7711 gold badge9 silver badges27 bronze badges

1 Comment

David Thomas Over a year ago

Because he was using regular expressions, not strings.

Collectives™ on Stack Overflow

jQuery replace text not working

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related