jquery grid and javascript best practice

Question

Im new to jquery and need some help.

I have written a table that act like a grid with help from jquery.

When a user click on Name column the user will be redirected to the details page.

Now I want to know if I can do this in a better way?

And should the JS code be in the page or in a separated JS file?

Here is the code.

    <table id="grid">
    <thead>
        <tr>
            <th data-field="name">Namn</th>
            <th data-field="location">Ort</th>
            <th data-field="phone">Telefon</th>
            <th data-field="buildinmonth">Bygga inom</th>
            <th data-field="houselot">Har tomt</th>
            <th data-field="created">Skapad</th>
        </tr>
    </thead>
    <tbody>
        @foreach (var item in Model)
        {
            <tr>
                <td><span id="open" data-id="@item.Id">@item.Name</span></td>
                <td>@item.Location</td>
                <td>@item.Phone</td>
                <td>@item.BuildInMonth</td>
                <td>@item.HouseLot</td>
                <td>@String.Format("{0:d}", item.CreatedDate)</td>
            </tr>
        }
    </tbody>
</table>

<script>
        $("#grid").kendoGrid({
            scrollable: false,
            sortable: true
        });

    $("#grid #open").click(function () {
        window.location.replace("/lead/details/" + $(this).data("id"));
    });
</script>

javacode? What is this language you speak of?

PitaJ
– PitaJ

2012-11-06 22:55:13 +00:00
Commented Nov 6, 2012 at 22:55 — PitaJ
– PitaJ, Commented Nov 6, 2012 at 22:55

Manikandan Sethuraju · Accepted Answer · 2012-11-07 06:10:11Z

2

In this scenario, dont need to use any jquery click event, when the html table is loading that time we can give a <a> tag like,

<td><a href="../lead/details/"+"@item.Id" ><span id="open" data-id="@item.Id">@item.Name</span></a></td>

edited Nov 7, 2012 at 6:10

answered Nov 7, 2012 at 6:00

Manikandan Sethuraju

2,90110 gold badges32 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Yasser Shaikh · Accepted Answer · 2012-11-07 05:34:58Z

1

When a user click on Name column the user will be redirected to the details page. Now I want to know if I can do this in a better way?

This seems ok. The only thing I feel can be adde to this is on hover of the Name column, you can show a tooltip of "Show more details" or something more intuitive.

And should the JS code be in the page or in a separated JS file?

Yes I always prefer to have all my JS code in a seperate file. The advantage of doing so is that you can minify the JS code later on.

answered Nov 7, 2012 at 5:34

Yasser Shaikh

47.9k50 gold badges208 silver badges289 bronze badges

Collectives™ on Stack Overflow

jquery grid and javascript best practice

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related