Reuse MySQL connection PHP object inheritance

Question

I'm writing a single PHP script to migrate topics from an old forums site to a new one.

The old forums site use database "old_forums"
Thew new forums site use database "new_forums"
MySQL user "forums" has all privileges to both databases (I'm using 1 single user for convenience but I would not have any problems using 2 different users if required)

I have both forum hosted on the the same host - localhost

The script I have the following structure

<?php  
class Forum {  
   //constants  
   const HOST = "localhost";  
   const DB_USER = "forums";  
   const DB_PASS = "forums";  
   ...  
   //properties e.g. topic title, topic content
}
class OldForum extends Forum {  
   const DB_NAME_OLD = "old_forums";  
   public static function exportTopics() {  
       //some code
   }  
}
class NewForum extends Forum {
   const DB_NAME_NEW = "new_forums";
   public static function importTopics() {  
       //some code
   }
}  
OldForum::exportTopics();  
NewForum::importTopics();  
?>

I understand that I'm mixing procedural & object-oriented programming PHP (OOPP) here. I'm new to object-oriented PHP but (I have experience with Java so I'm very open to some guide to make this pure OOPP)

I would like to ultilise 1 single MySQL connection for both OldForum and NewForum class.
Where should I instantiate a mysqli object?
e.g. inside Forum class' constructor or have a new mysqli object as a property of class Forum
so that I would create a new Forum object to initiate a MySQL connection

$a_forum = new Forum();

That's not "OOP", it's just namespaced procedural code. Anyway, you have a number of questions in there, which is the real hangup for you? Why can't you instantiate a mysqli connection and pass it into your methods? — deceze
– deceze ♦, Commented Nov 7, 2012 at 10:53
Hi @deceze, thanks, rephrasing my question now. I'm planning to have the database name as 1 constant in OldForum and NewForum class, would that be very wrong in any way? — ericn
– ericn, Commented Nov 7, 2012 at 12:24

Community · Accepted Answer · 2017-05-23 10:27:04Z

2

The mysqli connection is easy enough to share between instances by creating it once in your bootstrap file and then passing it to instances that need it, e.g.

$mysqli = new mysqli(/* connection params */);
$someClassUsingMySqli = new SomeClassUsingMySqli($mysqli);
$anotherClassUsingMySqli= new AnotherClassUsingMySqli($mysqli);

That will effectively limit the connection to one and you dont need to resort to globals inside your objects. This is called Dependency Injection and should be your prefered way of assigning dependencies to objects. It makes dependencies explicit and easy to swap out and thus benefits change, testing and maintenance.

As for your Import and Export Task, I wonder why you are doing this in PHP at all. It's apparently the same database server, so you could just do it inside your MySql instance. If you want to do it with PHP, I'd probably do something like this:

class MigrateForum
{
    private $dbConnector;

    public function __construct(DBConnector $dbConnector)
    {
        $this->dbConnector = $dbConnector;
    }

    public function migrate()
    {
        // orchestrate the migration (consider transactions)
        $this->exportOldForum();
        $this->importNewForum();
    }

    private function exportOldForum()
    {
        // code to export old_database_name.table_name 
    }

    private function importOldForum()
    {
        // code to import new_database_name.table_name 
    }
}

You could extract the Import and Export methods into their own Classes and then use some sort of Composite Command Pattern, but that really depends on how modular you need this to be.

edited May 23, 2017 at 10:27

CommunityBot

11 silver badge

answered Nov 8, 2012 at 8:05

Gordon

318k76 gold badges548 silver badges566 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ericn Over a year ago

You made realise there is no need to have 3 classes at all :D I need PHP or other server-side scripting language because the database structure of the old forum is different from the new one. I'm unclear about the boostrapping concept at the moment but I definitely know how to proceed from here. Will read up on bootstrap as well. Cheers, @Gordon!

GregD · Accepted Answer · 2012-11-07 12:52:44Z

1

Different approach would be to create some VIEW in the new_forums database pointing to the old_forum database. In this case, all the "views" could have, for example, "old_" prefix? Something similar to this:

CREATE VIEW old_tbl_name AS
     SELECT *
       FROM old_forum.tbl_name

In such situation, you only have one connection to one database.

answered Nov 7, 2012 at 12:52

GregD

2,8773 gold badges31 silver badges42 bronze badges

Collectives™ on Stack Overflow

Reuse MySQL connection PHP object inheritance

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related