Getting null value in controller MVC3

Question

I am newer to MVC3 and have a controller with one action.I defined some global properties in controller class and assigned values to those properties in action method. ex:

  public class RosterController : Controller
   {
   int var1;
   int var2;
   int var3;
   public ActionResult Index(int param1)
   {
      if(param1 ==1)
      {
         return view(newRosterViewModel(var1+1,var2+2,var3+3));
      }
      else
      {
         var1=1;
         var2=2;
         var3=3;
         return view(newRosterViewModel(var1,var2,var3));
      }
      }
   }

In this code first time assigning values to var1,var2,var3. second time I need those vaues but values are null.

I tried with TempData but that also not holding value.

Richard · Accepted Answer · 2012-11-09 16:33:15Z

2

but values are null.

I think you'll find their values are 0 (zero), this is the default value for integral fields.

Every request mapped to RosterController will cause a new instance of RosterController to be created, this avoids any issues with concurrent requests mixing up their controller state.

To persist information from one request to another there are many options (database, Session, cookies, Application, …), but the state of a controller instance is not one of them. The right approach to persistence across requests depends on the requirements.

edited Nov 9, 2012 at 16:33

answered Nov 9, 2012 at 8:43

Richard

110k21 gold badges214 silver badges279 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dove · Accepted Answer · 2012-11-09 08:42:40Z

1

Why not make them static?

private static int var1;

or use Cache or Session

HttpRuntime.Cache.Add("var1", value);

var var1= HttpRuntime.Cache.Get("var1");

answered Nov 9, 2012 at 8:42

dove

20.8k14 gold badges88 silver badges109 bronze badges

Comments

Yasser Shaikh · Accepted Answer · 2012-11-09 08:47:09Z

1

You can make your variables static. Making your variables static means - thier lifetime extends across the entire run of the program.

declare static like this

private static int var1;
private static int var2;
private static int var3;

But first please tell us your exact Use case

answered Nov 9, 2012 at 8:47

Yasser Shaikh

47.9k50 gold badges208 silver badges289 bronze badges

Comments

karaxuna · Accepted Answer · 2012-11-09 12:23:52Z

0

When you render view you should pass this variables to controller again, because on every request controller is recreated:

public class RosterController : Controller
{
int var1 = 0;
int var2 = 0;
int var3 = 0;
public ActionResult Index(int param1, int var1, int var2, int var3)
{
  if(param1 ==1)
  {
     return view(newRosterViewModel(var1+1,var2+2,var3+3));
  }
  else
  {
     var1=1;
     var2=2;
     var3=3;
     return view(newRosterViewModel(var1,var2,var3));
  }
  }
}

answered Nov 9, 2012 at 12:23

karaxuna

26.9k13 gold badges86 silver badges120 bronze badges

Collectives™ on Stack Overflow

Getting null value in controller MVC3

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related