Java Software testing

Question

I am revising for a test upcoming this week using previous exam questions and I just can't get 100% coverage, my program is :

public int computeInsurance(boolean SportsEquipment, boolean MusicEquipment)
{
int insurance;
if(SportsEquipment == true && MusicEquipment==true)
insurance = 20;
else if((SportsEquipment == true && MusicEquipment == false)||(SportsEquipment == false        && MusicEquipment == true))
        insurance = 10;
    else
        insurance= 5;

    return insurance;
}

}

I am using the following test cases:

public class Lab5CarTest {

@Test
public void testComputeInsurance() {
    Lab5Car t = new Lab5Car();

    int result = t.computeInsurance(true, true);
    assertEquals(20,result);

    int i = t.computeInsurance(true,false);
    assertEquals(10,i);

    int u = t.computeInsurance(false,false);
    assertEquals(5,u);


}

}

But I am missing 3 branches out of 8 in the else if line of my code!

add "int i = t.computeInsurance(false,true);" and see what you get — bobah
– bobah, Commented Nov 11, 2012 at 18:35
Ahh i should have seen that one! But still after I add that line, I still am missing 2 branches out of 8 from my else if line of code! — user1816464
– user1816464, Commented Nov 11, 2012 at 19:36

Frank · Accepted Answer · 2012-11-11 19:44:34Z

3

Why don't you test for:

int ip = t.computeInsurance(false,true);
assertEquals(10,ip);

Like this you should cover all.

you can simplify your code like this:

if (SportsEquipment && MusicEquipment)
    insurance = 20;
else if (SportsEquipment != MusicEquipment)
    insurance = 10;
else
    insurance= 5;

edited Nov 11, 2012 at 19:44

answered Nov 11, 2012 at 18:34

Frank

15.7k6 gold badges38 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1816464 Over a year ago

Ahh i should have seen that one! But still after I add that line, I still am missing 2 branches out of 8 from my else if line of code!

Frank Over a year ago

Try updating your if tree like Joop did show below. I did copy it to my answer to be complete.

Joop Eggen · Accepted Answer · 2012-11-11 18:43:42Z

0

1 out of 4 (=2²) you are missing (not 2³), t.computeInsurance(false, true);

S M  I
------
t t 20
t f 10
f t 10
f f  5


if (SportsEquipment  && MusicEquipment)
    insurance = 20;
else if (SportsEquipment != MusicEquipment)
    insurance = 10;
else
    insurance= 5;

answered Nov 11, 2012 at 18:43

Joop Eggen

110k8 gold badges89 silver badges142 bronze badges

Collectives™ on Stack Overflow

Java Software testing

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related