Accepting user input in a while loop

Question

I'm trying to create a simple temperature conversion program that allows the user to convert temperatures as many times as they want until they decide to end the program by entering the letter 'e'. Everything else in the code works except the part where the user enters the letter 'e'. If I take the last else statement out, the program just starts at the beginning of the loop again. If I leave the else statement in, when the user enters the letter 'e', the else statement thinks that it is invalid input and does not end the program.

 #include <iostream>

using namespace std;

float celsiusConversion(float cel){     // Calculate celsius conversion
    float f;

    f = cel * 9/5 + 32;
    return f;
}

float fahrenheitConversion(float fah){  // Calculate fahrenheit conversion
    float c;

    c = (fah - 32) * 5/9;
    return c;

}
int main()
{
    char userInput;

        while (userInput != 'e' or userInput != 'E')    // Loop until user enters the letter e
        {

            cout << "Please press c to convert from Celsius or f to convert from Fahrenheit. Press e to end program." << endl;
            cin >> userInput;


            if (userInput == 'c' or userInput == 'C') // Preform celsius calculation based on user input 
                {
                    float cel;
                    cout << "Please enter the Celsius temperature" << endl;
                    cin >> cel;
                    cout << cel << " Celsius is " << celsiusConversion(cel) <<  " fahrenheit" << endl;
                }
            else if (userInput == 'f' or userInput == 'F')  // Preform fahrenheit calculation based on user input
                {
                    float fah;
                    cout << "Please enter the Fahrenheit temperature" << endl;
                    cin >> fah;
                    cout << fah << " Fahrenheit is " << fahrenheitConversion(fah) << " celsius" << endl;
                }
            else    // If user input is neither c or f or e, end program
                {
                    cout << "Invalid entry. Please press c to convert from Celsius, f to convert from Fahrenheit, or e to end program." << endl;
                }
        }
    return 0;
}

You can't respond to individual key presses with only the standard library. You'll at least need to read an entire line of input. And for that there are thousands of duplicates already on SO. — Kerrek SB
– Kerrek SB, Commented Nov 12, 2012 at 17:54

pm100 · Accepted Answer · 2012-11-12 17:56:12Z

2

you mean while(userInput != 'e' && userInput != 'E')

the 'or' version is always true

answered Nov 12, 2012 at 17:56

pm100

50.6k25 gold badges95 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tydis Over a year ago

so that did end the program, but not before printing out the else line. any advice on how to fix that? EDIT: Never mind, I just changed the last else statement to: else if (userInput != 'e')

Rodrigo Guedes · Accepted Answer · 2012-11-12 18:05:04Z

1

I'd make 2 changes in your code:

while (userInput != 'e' && userInput != 'E')

And, just before the "else" (to prevent the error message when exiting the program):

else if (userInput == 'e' or userInput == 'E')
             {
                break;
             }

answered Nov 12, 2012 at 18:05

Rodrigo Guedes

1,1832 gold badges13 silver badges27 bronze badges

Collectives™ on Stack Overflow

Accepting user input in a while loop

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related