Using in-line javascript to change the value of a radio button

Question

I have a form with two radio buttons. One button id'd as 'trigger_unit', the other as 'normal_unit'. There is also a select drop down with four values and a default NULL value.

<select rel="dropdown" name="trigger_id" id="trigger_id" 
onchange="((this.value != '') ? document.getElementById('trigger_unit').checked=true : 
document.getElementById('normal_unit').checked=true;)" style="width: 120px;">
<option value="" selected="selected">--none--</option>
<option value="1">Critical</option>
<option value="2">Draw</option>
<option value="4">Heal</option>
<option value="3">Stand</option>
</select>

What's supposed to happen is the javascript is supposed to change the value of the radio button if there is a non-blank value from the drop down. I tried to follow the in-line IF example here but it's not exactly working. Can this be done or do I HAVE to write a second function?

adhocgeek · Accepted Answer · 2012-11-13 14:10:26Z

3

There's a shorter bit of javascript that would work for your onchange handler :

document.getElementById(this.value != '' ? 'trigger_unit' : 'normal_unit').checked=true;

i.e.

<select rel="dropdown" name="trigger_id" id="trigger_id" 
    onchange="document.getElementById(
            this.value != '' ? 'trigger_unit' : 'normal_unit'
        ).checked=true;" 
        style="width: 120px;">
    <option value="" selected="selected">--none--</option>
    <option value="1">Critical</option>
    <option value="2">Draw</option>
    <option value="4">Heal</option>
    <option value="3">Stand</option>
</select>

answered Nov 13, 2012 at 14:10

adhocgeek

1,4771 gold badge16 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MassivePenguin · Accepted Answer · 2012-11-13 14:07:33Z

2

Looks like you have an errant ; in your code...

This fiddle works: http://jsfiddle.net/bxLfu/

The code is the same as yours, but without the ;:

<select rel="dropdown" name="trigger_id" id="trigger_id" 
onchange="((this.value != '') ? document.getElementById('trigger_unit').checked=true : 
document.getElementById('normal_unit').checked=true)" style="width: 120px;">
<option value="" selected="selected">--none--</option>
<option value="1">Critical</option>
<option value="2">Draw</option>
<option value="4">Heal</option>
<option value="3">Stand</option>
</select>

answered Nov 13, 2012 at 14:07

MassivePenguin

3,5194 gold badges30 silver badges48 bronze badges

Comments

Pranav 웃 · Accepted Answer · 2012-11-13 14:07:49Z

2

In the ternary condition above, the end semi-colon before closing braxket would give a syntax error :

((this.value != '') ? document.getElementById('trigger_unit').checked=true : 
document.getElementById('normal_unit').checked=true;)

Change it to :

(this.value != '') ? document.getElementById('trigger_unit').checked=true : 
document.getElementById('normal_unit').checked=true;

Have a look at the fiddle

answered Nov 13, 2012 at 14:07

Pranav 웃

8,4676 gold badges41 silver badges48 bronze badges

Collectives™ on Stack Overflow

Using in-line javascript to change the value of a radio button

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related