Java Script issue

Question

For my studies I need to create a simple script that checks if the entered data (suppose to be a 5 digit zip code) actually has 5 digits. If more or less then 5 digits entered, a alert should pop up.

So far I managed to get the alert for more and less then a 5 digit entry, but even when entering 5 digits, the alert will come up as well.

Since js is not my favourite subject I am lost, even tho it seems to be a simple thing.

Thanks in advance for answers and hints.

<script type="text/javascript"> 
<!--
function CheckZip ()
{
var content = document.forms['zipfield'].Field.value;
var length = content.length;
if (length >=5) (alert('Please enter a 5 digit zip code!'));
else if (length <=5) (alert('Please enter a 5 digit zip code!'));
else (length ==5) (alert('Valid entry'))
}
//-->
</script> 
</head> 
<body>  
<div align="left">
<p>Please enter a 5 digit zip code</p> 
<form name="zipfield" action="post"><input name="Field" size="5">
<br />
<br />
<input name="check" value="Check entry" onclick="CheckZip()" type="submit"> 
</form>

Use a good title to attract the attention of people who can help! — kojiro
– kojiro, Commented Nov 13, 2012 at 21:07
Also, please consider indenting your code, markup, etc--it makes this significantly easier for humans to read. — Dave Newton
– Dave Newton, Commented Nov 13, 2012 at 21:10

frenchie · Accepted Answer · 2012-11-13 21:07:24Z

3

How about this:

if (content.length !== 5) {

   alert('Please enter a 5 digit zip code!');

} else {

   alert('Valid entry');
}

answered Nov 13, 2012 at 21:07

frenchie

52.3k117 gold badges321 silver badges531 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sushanth -- · Accepted Answer · 2012-11-13 21:12:55Z

Check your condition..

When length is 5 it will go to the first if statemenet because you have specified it to be >= 5

So when length is 5 , it will never hit the statement else (length ==5)

if (length >5) {
      alert('Please enter a 5 digit zip code!')
}
else if (length <5) {
    alert('Please enter a 5 digit zip code!')
}
else (length ==5) {
     alert('Valid entry')
};

Better

if( length === 5){
   alert('Valid entry');
}
else{
   alert('Please enter a 5 digit zip code!');
}

Check Fiddle

You have other syntax errors in your script

if (length >=5) (alert('Please enter a 5 digit zip code!'));
              --^-- Supposed to be {                    --^-- supposed to be }

Also you are ending the if loop with a semicolon ; .. Need to remove that .. Otherwise the statement in else if and else will never be executed

Niet the Dark Absol · Accepted Answer · 2012-11-13 21:07:11Z

2

5 is greater than or equal to 5, so the error alert will come up.

You should be using > and <, instead of >= and <=.

answered Nov 13, 2012 at 21:07

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Comments

Matt Burland · Accepted Answer · 2012-11-13 21:07:38Z

2

>= means greater than or equal to, <= means less than or equal to. Your problem is that if your input is exactly 5 characters long then:

if (length >=5)

Will evaluate as true, and you won't get to your else statement.

answered Nov 13, 2012 at 21:07

Matt Burland

45.3k18 gold badges110 silver badges182 bronze badges

Collectives™ on Stack Overflow

Java Script issue

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related