Using PHP variable to search a value in an array and then remove it

Question

Hey guys im trying to search an array for an value and then remove it. But im searching with a php variable and that seems to be the problem. So this is what I have so far:

if(isset($_REQUEST['Admin'])){
    $arr = array('HAUGMA1', 'sdasd', 'dasdasda', 'sadasd');
    $key=array_search($_REQUEST['Admin'],$arr);
    if($key!==false) 
        unset($arr[$key]);
    print_r($arr);
}

The $_REQUEST retrieves the value HAUGMA1 but when I print out the array it didn't remove HAUGMA1 from it. What am I doing wrong? When I'm using this:

$key=array_search('HAUGMA1',$arr);

It is working.

what is the actual value of $_REQUEST['Admin'] when you echo it? — thescientist
– thescientist, Commented Nov 15, 2012 at 13:47
you have used second if wrong. it should be if($key!=FALSE) — Abhishek Bhatia
– Abhishek Bhatia, Commented Nov 15, 2012 at 13:47
@AbhishekBhatia not according to the manual... php.net/manual/en/function.array-search.php — thescientist
– thescientist, Commented Nov 15, 2012 at 13:48

Fred Wuerges · Accepted Answer · 2012-11-15 13:59:29Z

1

I think the problem is in relation to the value that is coming from the $_REQUEST variable.
I made the following test to show two questions:

//Array definition
$arr = array('HAUGMA1', 'sdasd', 'dasdasda', 'sadasd');
//Search
$admin = 'dasdasda';

/* First sample */

$time = microtime();

$arr = array_filter($arr, function($key) use($admin) {
    return $key != $admin;
});

print_r($arr);
echo '<br>Execution time: '.(microtime()-$time).'<br>';

/* Second sample */

$time = microtime();

$key = array_search($admin, $arr);
if($key !== false)
    unset($arr[$key]);

print_r($arr);
echo '<br>Execution time: '.(microtime()-$time).'<br>';

First: using the array_search has approximately 4x faster than array_filter.

Second: the way that your script is, the item is removed from the array without problem. Try to debug the value that is coming from the variable $_REQUEST

answered Nov 15, 2012 at 13:59

Fred Wuerges

1,9652 gold badges21 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Alesfatalis Over a year ago

an var_dump of $_REQUEST['Admin'] gives me string(9) "HAUGMA1 "

Fred Wuerges Over a year ago

That's the problem. Use the "trim" to remove extra spaces in $_REQUEST variable: array_search(trim($_REQUEST['Admin']), $arr);

silly · Accepted Answer · 2012-11-15 13:48:40Z

0

try this (closure PHP >= 5.3)

$admin = $_REQUEST['Admin'];

$arr = array_filter($arr, function($key) use($admin) {
    return $key != $admin;
});

answered Nov 15, 2012 at 13:48

silly

7,8972 gold badges26 silver badges37 bronze badges

Comments

fxbt · Accepted Answer · 2012-11-15 13:52:12Z

0

When i set manually $_REQUEST['Admin'] to "HAUGMA1", it's working. Are you sure there is no whitespace in the beginning or the end of your string ?

Try with this :

$key = array_search(trim($_REQUEST['Admin']), $arr);

answered Nov 15, 2012 at 13:52

fxbt

2,59621 silver badges19 bronze badges

1 Comment

h2ooooooo Over a year ago

In Wayne Whitty's response he used strtoupper and trim and the OP said that it still wasn't working.

user399666 · Accepted Answer · 2012-11-15 13:53:48Z

0

array_search is case sensitive. Use strtoupper and trim in order to conform the incoming variable to the values in your array. trim() will get rid of trailing white space and other unwanted characters.

if(isset($_REQUEST['Admin'])){
    $arr = array('HAUGMA1', 'SDASD', 'ETC');
    $key = array_search(strtoupper(trim($_REQUEST['Admin'])), $arr);
    if($key !== false){ 
        unset($arr[$key]);
    }
    print_r($arr);
 }

edited Nov 15, 2012 at 13:53

answered Nov 15, 2012 at 13:46

user399666

20k7 gold badges49 silver badges68 bronze badges

3 Comments

Alesfatalis Over a year ago

nope not wokring result is:Array ( [0] => HAUGMA1 [1] => SDASD [2] => ETC )

user399666 Over a year ago

Can you var_dump($_REQUEST['Admin']) and tell us the result?

Alesfatalis Over a year ago

The result is: string(9) "HAUGMA1 "

Collectives™ on Stack Overflow

Using PHP variable to search a value in an array and then remove it

4 Answers 4

2 Comments

Comments

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related