C# Foreach Loop Issue

Question

I was just making this program to experiment with lists and such, and I was curious as to why in the foreach loop the Object always shows up as the "Minecraft" Wish object. Is it because it was the last Wish object to be created? And how can I fix it, so all 3 Wish objects which have been declared show up? Thanks!

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace ConsoleApplication1
{
    class Program
    {
        static void Main(string[] args)
        {
            Wish iPod = new Wish("iPod", "Various", 299.00);
            Wish Phone = new Wish("New Phone", "Various", 00.00);
            Wish Minecraft = new Wish("Minecraft Account", "www.minecraft.net", 30.00);

            List<Wish> Wishlist = new List<Wish>();
            Wishlist.Add(Phone);
            Wishlist.Add(iPod);
            Wishlist.Add(Minecraft);
            Console.WriteLine("Toby's Wishlist");
            Console.WriteLine("If cost is 00.00, the Wish's cost varies.");
            Console.WriteLine("              ");
            foreach (Wish wish in Wishlist)
            {
                Console.WriteLine("---Wish---");
                Console.WriteLine("Name: {0}", wish.getName());
                Console.WriteLine("Store: {0}", wish.getStore());
                Console.WriteLine("Cost: ${0}", wish.getCost().ToString());
                Console.WriteLine("----------");
                Console.WriteLine("           ");
            }
            Console.ReadLine();

        }
    }
    public class Wish
    {
        static string Name, Store;
        static double ApproxCost;
        public Wish(string name, string store, double approxCost)
        {
            Name = name;
            Store = store;
            ApproxCost = approxCost;
        }

        public string getName()
        {
            return Name;
        }
        public string getStore()
        {
            return Store;
        }
        public double getCost()
        {
            return ApproxCost;
        }
    }
}

You might want to consider Decimal type for cost instead of Double. — John Alexiou
– John Alexiou, Commented Nov 18, 2012 at 0:39

zerkms · Accepted Answer · 2012-11-18 00:13:23Z

8

Remove static from Wish members declaration

static means that the data will be shared across all the instances. So static members are also so called class variables. While not static members - are object variables.

answered Nov 18, 2012 at 0:13

zerkms

256k73 gold badges447 silver badges551 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Josh Grosso Over a year ago

@TobyTurnerMay If the answer was the most helpful, mind marking it as Accepted (i.e. clicking the green checkbox)? It helps the community know which answer actually solved the problem and rewards the person who helped you.

Reza Sadr · Accepted Answer · 2012-11-18 00:13:46Z

1

It's because in class Wish you declared Name, Score, and ApproxCost as static.

answered Nov 18, 2012 at 0:13

Reza Sadr

2731 silver badge5 bronze badges

Collectives™ on Stack Overflow

C# Foreach Loop Issue

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related