Modifying PHP rand function

Question

For testing and learning purpose, I wanted to modify the php rand and mt_rand functions which are in https://github.com/php/php-src:ext/standard/rand.c.

I wanted to give a fixed output each time rand function is called and for this purpose I modified the code

PHPAPI long php_rand(TSRMLS_D)
{
    long ret;

    if (!BG(rand_is_seeded)) {
        php_srand(GENERATE_SEED() TSRMLS_CC);
    }

#ifdef ZTS
    ret = php_rand_r(&BG(rand_seed));
#else
# if defined(HAVE_RANDOM)
    ret = random();
# elif defined(HAVE_LRAND48)
    ret = lrand48();
# else
    ret = rand();
# endif
#endif

    // ignoring the results coming from the calls above and 
    // returning a constant value 
    ret = 3264;

    return ret;
}

compiled

./configure
make
make install

and finally called the rand function as echo rand(3000,4000); and it always returns 3000.

What would be the way to modify this function? and why there is TSRMLS_D but not the range parameters?

Tthis a c question not a php one.

user557846
– user557846

2012-11-19 18:47:16 +00:00
Commented Nov 19, 2012 at 18:47 — user557846
– user557846, Commented Nov 19, 2012 at 18:47
@Dagon I missed that, thanks for correcting!

amertkara
– amertkara

2012-11-19 22:09:55 +00:00
Commented Nov 19, 2012 at 22:09 — amertkara
– amertkara, Commented Nov 19, 2012 at 22:09

Brian Campbell · Accepted Answer · 2012-11-19 19:04:11Z

2

The actual function that is called from PHP is the one declared PHP_FUNCTION(rand), which calls the php_rand() function that you modified. It does the following:

PHP_FUNCTION(rand)
{
    long min;
    long max;
    long number;
    int  argc = ZEND_NUM_ARGS();

    if (argc != 0 && zend_parse_parameters(argc TSRMLS_CC, "ll", &min, &max) == FAILURE)
        return;

    number = php_rand(TSRMLS_C);
    if (argc == 2) {
        RAND_RANGE(number, min, max, PHP_RAND_MAX);
    }

    RETURN_LONG(number);
}

As you can see, if you pass 2 parameters in, it calls the RAND_RANGE macro, which transforms the result of php_rand() into the range given.

#define RAND_RANGE(__n, __min, __max, __tmax) \
    (__n) = (__min) + (long) ((double) ( (double) (__max) - (__min) + 1.0) * ((__n) / ((__tmax) + 1.0)))

If you want it always to output a given value, I would recommend modifying PHP_FUNCTION(rand), instead of php_rand().

Though if all you're looking for is stable random number outputs, so that you get the same result every time, if you don't care about the exact result, you can just call srand(0) at the beginning of your program, to seed the random number generator with a constant value. This will mean that the random number generator will always give you the same sequence of random numbers, which is useful for testing purposes, and can be done without patching PHP itself.

answered Nov 19, 2012 at 19:04

Brian Campbell

335k59 gold badges367 silver badges344 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

amertkara Over a year ago

Thanks alot! I modified the PHP_FUNCTION(rand) and it worked. I will work on that function rather than php_rand.

amertkara Over a year ago

Actually, the main reason of the modification is not to give fixed output, I wanted to test some stuff on rand and mt_rand. Fixed output was just to understand how things work.

Brian Campbell Over a year ago

@acidrous Fair enough, I figured that was probably the case, but wanted to make sure I included the comment about srand() in case that's the reason you were doing it.

whamma · Accepted Answer · 2012-11-19 18:57:14Z

0

Look at the RAND_RANGE macro define in php_rand.h. It does some additional permutation/scrambling of the input value to make it fit between the range you've specified.

If you really want the rand() function to return 3264 even if that doesn't fit within the parameters passed to rand(), remove this block in rand.c:

    if (argc == 2) {
    RAND_RANGE(number, min, max, PHP_RAND_MAX);
}

If you still want to consider min/max, you're going to need to figure out what you want that to actually do if you specify a min/max that doesn't include your hardcoded number.

answered Nov 19, 2012 at 18:57

whamma

8,3781 gold badge17 silver badges19 bronze badges

Collectives™ on Stack Overflow

Modifying PHP rand function

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related