PHP SQL Connect

Question

For some reason my SQL won't connect any idea's? I used functions to connect to the SQl but having some trouble because it tells me the the $row_results gives back no data.

function db_connect() {
$db_connect = mysql_connect($db_host, $db_user, $db_pass);
if (!$db_connect)
{
    die('Can not connect: ' . mysql_error());
}
mysql_select_db($db_name, $db_connect);
}

function db_close() {
    mysql_close($db_connect);
}

function db_select($table_name, $table_where) {
    $row_result = mysql_query("SELECT * FROM '$table_name' WHERE email='$table_where'");
    $row_get = mysql_fetch_array($row_result);
    $row_count = mysql_num_rows($row_result);
}


db_connect();

db_select("attachments", "[email protected]");
die($row_get['email']);

db_close();

Please don't use mysql_* functions in new code. They were removed from PHP 7.0.0 in 2015. Instead, use prepared statements via PDO or MySQLi. See Why shouldn't I use mysql_* functions in PHP? for more information. — Waleed Khan
– Waleed Khan, Commented Nov 19, 2012 at 21:04
The syntax highlighting shows that your script has an error. — Waleed Khan
– Waleed Khan, Commented Nov 19, 2012 at 21:05
Do not use mqsql_* functions. Use mysqli or PDO. There is a syntax error on die('Can't connect: ' . mysql_error()); where you need to escape the apostrophe in "Can\'t" — Samuel Cook
– Samuel Cook, Commented Nov 19, 2012 at 21:05
You need to replace die('Can't connect: ' with die("Can't connect: " for starters... — Lucas
– Lucas, Commented Nov 19, 2012 at 21:05

jeroen · Accepted Answer · 2012-11-19 21:12:01Z

2

One problem I can see, is this function:

function db_select($table_name, $table_where) {
    $row_result = mysql_query("SELECT * FROM '$table_name' WHERE email='$table_where'");
    $row_get = mysql_fetch_array($row_result);
    $row_count = mysql_num_rows($row_result);
}

You are not returning anything from it.

You could start by using for example:

function db_select($table_name, $table_where) {
    $row_result = mysql_query("SELECT * FROM '$table_name' WHERE email='$table_where'");
    $row_get = mysql_fetch_array($row_result);
    $row_count = mysql_num_rows($row_result);

    return array($row_count, $row_get);
}

And you really need to switch to prepared statements with bound variables in PDO or mysql to avoid the sql injection problem you have now.

answered Nov 19, 2012 at 21:12

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Sammitch Over a year ago

Ahh yes, variable scoping. Nice catch.

Raffaele Izzia · Accepted Answer · 2012-11-19 21:07:34Z

0

change this

if (!$db_connect)
{
    die('Can\'t connect: ' . mysql_error());
}

answered Nov 19, 2012 at 21:07

Raffaele Izzia

2421 gold badge3 silver badges14 bronze badges

2 Comments

minute acc Over a year ago

I know that wasn't the problem through I only changed it to can't for stackoverflow.

Raffaele Izzia Over a year ago

Try to print your query and put it directly in sql. do you have any result?

Robert Rhea · Accepted Answer · 2012-11-19 21:10:16Z

0

Try This:

$db_config = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
        /* check connection */
if (mysqli_connect_errno()) {
    printf("Connect failed: %s\n", mysqli_connect_error());
    exit();
}

For later versions of PHP its is recommended to use the improved MySQL library.

answered Nov 19, 2012 at 21:10

Robert Rhea

1

Comments

Sammitch · Accepted Answer · 2012-11-19 21:11:42Z

0

In this line you have quotes around the table name.

$row_result = mysql_query("SELECT * FROM '$table_name' WHERE email='$table_where'");

Do not put quotes around the table name. Running mysql_error() after the select will likely spit back an error relating to this.

Also, mysql_* are being deprecated. You should be using mysqli_* or PDO.

answered Nov 19, 2012 at 21:11

Sammitch

32.5k7 gold badges57 silver badges92 bronze badges

Comments

artragis · Accepted Answer · 2012-11-19 21:13:07Z

0

you've got a problem with your variables. outside the function db_select the variable $row_get does not exist ! If you want to send your result in a new variable, yo've got to use return like that :

function db_select($table_name, $table_where,$connection) {

    $row_result = mysqli_query($connection,"SELECT * FROM $table_name WHERE email='".mysqli_real_escape_string($table_where).'");
    $row_get = mysqli_fetch_array($row_result);
    $row_count = mysqil_num_rows($row_result);
    return array($row_get,$row_count);
}


$var = db_select("attachments", "[email protected]", db_connect());
echo $var[0]['email'];

answered Nov 19, 2012 at 21:13

artragis

3,7031 gold badge21 silver badges32 bronze badges

Comments

Jackk · Accepted Answer · 2022-06-28 06:27:31Z

0

Document

List of Employees

ID First Name Last Name Email Phone Address Action connect_error) { die("Connection failed: " . $connection->connect_error); } // read all row from database table $sql = "SELECT * FROM employees"; $result = $connection->query($sql); if (!$result) { die("Invalid query: " . $connection->error); } // read data of each row while($row = $result->fetch_assoc()) { echo " " . $row["id"] . " " . $row["first_name"] . " " . $row["last_name"] . " " . $row["email"] . " " . $row["phone"] . " " . $row["address"] . " Update Delete "; }

$connection->close(); ?> this better

answered Jun 28, 2022 at 6:27

Jackk

11 bronze badge

1 Comment

Community Over a year ago

Your answer could be improved with additional supporting information. Please edit to add further details, such as citations or documentation, so that others can confirm that your answer is correct. You can find more information on how to write good answers in the help center.

Collectives™ on Stack Overflow

PHP SQL Connect

6 Answers 6

1 Comment

2 Comments

Comments

Comments

Comments

List of Employees

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

2 Comments

Comments

Comments

Comments

List of Employees

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related