Combine string with JSON.stringify (Javascript)

Question

Ok, this question may be dumb, but I'm really stuck with this.

I want to a json structure like the following:

order: {
    currency: 'eur',
    order_items: [
        {
            id: 3,
            quantity: 1
        },
        {
            id: 67,
            quantity: 1
        }
    ]
}

What I'm doing right now is this:

function makeOrder(){
    var myArray = new Array();
    for(var i=0;i<bookedItemsArray.length;i++){
        var newObject = new OrderedItem(bookedItemsArray[i].id, bookedItemsArray[i].amount);
        myArray.push(newObject);
    }
    var mystring = JSON.stringify(myArray);
    //myString = "order: {currency: 'eur', order_items: " + myString + "}";
    console.log(myString);
}

The way I get the data inside the order_items array is being cool, but when I try to concat the array with the rest (line in comments), I get:

?:??: W/?(?): Uncaught SyntaxError: Unexpected token ILLEGAL at file:///android_asset/www/november/js/t03/Booking/bookingProcess.js:96

Is there something I'm missing about the way a string and a JSON structure can be combined?

Thank you very much.

It’s difficult to understand the acutal question, please explain "concat the array with the rest (line in comments)". — David Hellsing
– David Hellsing, Commented Nov 20, 2012 at 10:00
Concatenating two valid JSON strings won't create a valid JSON strings (unless they both describe a number) — John Dvorak
– John Dvorak, Commented Nov 20, 2012 at 10:00
JSON.stringify(myArray) should always produce a valid JSON string unless the argument cannot be encoded. — John Dvorak
– John Dvorak, Commented Nov 20, 2012 at 10:04

J. Steen · Accepted Answer · 2012-11-20 10:32:13Z

1

why don't you do it like this?

var x = {
    order: {
        currency: 'eur',
        order_items: []
    }
};
for (var i = 0; i < 10; i++) {
    var newObject = {
        i: i,
        Text: 'Some Text'
    };
    x.order.order_items.push(newObject);
}

var str = JSON.stringify(x);

look at this fiddle: http://jsfiddle.net/9V6Vb/

Here is the generated JSON:

{
    "order": {
        "currency": "eur",
        "order_items": [{
            "i": 0,
            "Text": "Some Text"},
        {
            "i": 1,
            "Text": "Some Text"},
        {
            "i": 2,
            "Text": "Some Text"},
        {
            "i": 3,
            "Text": "Some Text"},
        {
            "i": 4,
            "Text": "Some Text"},
        {
            "i": 5,
            "Text": "Some Text"},
        {
            "i": 6,
            "Text": "Some Text"},
        {
            "i": 7,
            "Text": "Some Text"},
        {
            "i": 8,
            "Text": "Some Text"},
        {
            "i": 9,
            "Text": "Some Text"}]
    }
}

edited Nov 20, 2012 at 10:32

J. Steen

15.6k15 gold badges59 silver badges64 bronze badges

answered Nov 20, 2012 at 10:04

BuddhiP

6,5035 gold badges39 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

BuddhiP Over a year ago

Fixed the typo, but if I understand right, he is trying to do some string concatenation to get the final JSON representation. What he should do (in my opinion) is construct the full object and stringify that.

John Dvorak Over a year ago

He definitely should. I even think he does.

luisfer Over a year ago

This solution is exactly what I needed. Thanks a lot, @Raiden.

Thomas Leduc · Accepted Answer · 2012-11-20 10:19:56Z

As Koen say it, you can make an object with first property is order and stringify all object in one time.

var myOrder = {
order: {
currency: 'eur',
         order_items: [
           {
             id: 3,
             quantity: 1
           },
           {
             id: 67,
             quantity: 1
           }
         ]
      }
}
console.log("currency : " + myOrder.order.currency);
for (var i in myOrder.order.order_items) {
    console.log("items number " + i);
    console.log("items id" + myOrder.order.order_items[i].id);
    console.log("items quantity" + myOrder.order.order_items[i].quantity);
}
var myString = JSON.stringify(myOrder);
console.log(myString);

but I think you should make "order" your object direcly

Regards,

Koen. · Accepted Answer · 2012-11-20 16:58:50Z

0

JSON should be encapsulated in { and }.

So your JSON probably should be like:

{
    "order": {
        "currency": "eur",
        "order_items": [
            {
                "id": 3,
                "quantity": 1
            },
            {
                "id": 67,
                "quantity": 1
            }
        ]
    }
}

edited Nov 20, 2012 at 16:58

answered Nov 20, 2012 at 10:00

Koen.

27.3k7 gold badges87 silver badges80 bronze badges

9 Comments

John Dvorak Over a year ago

JSON.parse("[]") returns an array. JSON.parse("{a:1}") throws an exception.

Koen. Over a year ago

@JanDvorak You're right, updated my answer so all properties are between quotes.

John Dvorak Over a year ago

[1,2,3] is still valid JSON

Koen. Over a year ago

JSON.parse('{"order": {"currency": "eur", "order_items": [{"id": 3,"quantity": 1},{"id": 67,"quantity": 1}]}}') is valid

John Dvorak Over a year ago

As is JSON.parse('[1,2,3]'), so there need not be any curly brackets in valid JSON.

|

Collectives™ on Stack Overflow

Combine string with JSON.stringify (Javascript)

3 Answers 3

3 Comments

Comments

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related