Adding a comma to this foreach loop in wordpress

Question

I am wanting to separate these links that are outputted by a comma, but with no comma on the last link. What is the best way to achieve this?

<p class="favs">Favourite Courses: 
                <?php 
                    $user_id = bp_get_member_user_id();
                    $array = get_user_meta($user_id, 'wpfp_favorites', true); 

                    foreach ($array as $key => $value) {
                    $queried_post = get_post($value); ?>

                    <a href="http://publicaccessgolf.com.au/<?php echo $queried_post->post_name; ?>" title="<?php echo $queried_post->post_title; ?>" ><?php echo $queried_post->post_title; ?></a>

                 <?php } ?>
                </p>

deceze · Accepted Answer · 2012-11-20 10:35:29Z

4

The best way is typically this:

$links = array();
foreach (...) {
    $links[] = '<a ...';
}

echo join(', ', $links);

Adapt to your situation as appropriate.

answered Nov 20, 2012 at 10:35

deceze♦

525k89 gold badges806 silver badges954 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

deceze Over a year ago

implode = join, just saying. :)

user537137 Over a year ago

That is not working. I am taking the values (post id) from the array and using these values to get the post URL and title. So I need to echo out the URL and title, not the values from the array. If that makes sense? (probably not :)

deceze Over a year ago

@user Ever heard of string concatenation? "string" . $variable . "string"

user537137 Over a year ago

@deceze I have heard of string concatenation. How does that help what I am trying to do though?

deceze Over a year ago

Take a good look again at my answer. Instead of echoing out all the links and titles directly, put them into an array $links first. You make a new array. When you have an array full of such links and titles, output them using join, which puts in the right number of commas.

Collectives™ on Stack Overflow

Adding a comma to this foreach loop in wordpress

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related