PHP for loop - display data in table

Question

i can't understand why my code is not working; it is only displaying 1 result, whereas there are multiple entries in table..

<?php  

    $search = $_POST['search'];
    print ($search);
    $query  = "SELECT * FROM student WHERE county= 'sussex'";
    $result = mysql_query($query,$conn);
    $counter = 0;
    $z=0;
    while($row = mysql_fetch_assoc($result)){
    $id[$counter] = $row['roll_number'];
    $counter = $counter + 1;
    }
?>
<table border="1" id="table1" >
    <th>Id</th>
    <th>Type</th>
    <th>Description</th>
    <th>Operator Id</th>

<?
    if($counter>0)
    {
        for($z=0;$z<$counter;$z++)
        {
?> 
            <tr>
            <?
                if($z<$counter)
                {
            ?>
                <td >
                    <?php echo $id[$z]?>                            
                </td> 
            <?
                }
                $z = $z + 1;
            ?>   
            </tr>
</table>

SELECT * FROM student WHERE county= 'sussex' - There is your problem trying to finding a student in Sussex! — Ed Heal
– Ed Heal, Commented Nov 24, 2012 at 16:35

Nelson Benítez León · Accepted Answer · 2012-11-24 16:26:11Z

4

You forgot to close the FOR loop and its enclosing IF, I've done it below:

<?
if($counter>0)
{
    for($z=0;$z<$counter;$z++)
    {
?> 
        <tr>
            <?
                if($z<$counter)
                {
            ?>
                <td >
                    <?php echo $id[$z]?>                            
                </td> 
            <?
                }
                //$z = $z + 1;  <!-- REMOVE or comment out this line -->
            ?>   
            </tr>
     <? }
     }  ?> <!-- HERE we close the for loop and the IF -->
</table>

UPDATE: noted, thanks to VinceBurn, that $z was incremented twice

edited Nov 24, 2012 at 16:26

answered Nov 24, 2012 at 16:15

Nelson Benítez León

51k8 gold badges70 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Vincent Bernier Over a year ago

And Also you are incrementing $z at 2 different place.

Femme Fatale Over a year ago

its still not working...its display 1 entry and this line on html page. 0) { for($z=0;$z<$counter;$z++)

Collectives™ on Stack Overflow

PHP for loop - display data in table

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related