How to add (concatenate) to an existing PHP Array

Question

Would this work? I know you can concatenate variables this way.

    while ($row = mysql_fetch_array($result)) {
          $recipients[] = $row['phone'] . $row['carrier'];
    }

    while ($row = mysql_fetch_array($result)) {
        $recipients[] .= $row['email'];
    }

@Jack Yes, it does work in fact! But I feel like it's bad practice and got good ideas below. — TheLettuceMaster
– TheLettuceMaster, Commented Nov 27, 2012 at 0:13

Explosion Pills · Accepted Answer · 2012-11-26 23:50:45Z

1

It won't work since you have already reached the end of the fetch (i.e. mysql_fetch_array will always return false in the second loop).

Moreover, it probably wouldn't be a good idea if you wanted have some indicator of phone vs. email, but I guess you don't:

$phones = array();
$emails = array();
while ($row = mysql_fetch_assoc($result)) {
   $phones[] = $row['phone'] . $row['carrier'];
   $emails[] = $row['email'];
}
$recipients = $phones + $emails;

Also, didn't anyone tell you to use PDO or mysqli?

answered Nov 26, 2012 at 23:50

Explosion Pills

192k56 gold badges341 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

TheLettuceMaster Over a year ago

Yes, I will be converting to mysqli. I'm late ;)

TheLettuceMaster Over a year ago

Also, I like your answer. That looks good! My code worked, but this look more efficient.

Explosion Pills Over a year ago

Okay -- anyone reading this should apparently know that you can use mysql_fetch_array twice in a row!

Ja͢ck · Accepted Answer · 2012-11-26 23:56:43Z

1

Assuming you have two separate queries and they both return the same number of results in the exact same order, you should use a counter to help you find the right entry to modify:

$i = 0;
while ($row = mysql_fetch_array($result)) {
    $recipients[$i++] .= $row['email'];
}

answered Nov 26, 2012 at 23:56

Ja͢ck

174k39 gold badges269 silver badges316 bronze badges

Collectives™ on Stack Overflow

How to add (concatenate) to an existing PHP Array

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related